-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge inject_* paired methods #2445
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this! 🙏
@divagant-martian Could you please point out to me what line/ mapping in the autonat behaviour you are referring to? |
I think @divagant-martian mixed up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave the changelogs for later to avoid cluttering the diff for review.
Looks good to me overall apart from changelog entries and version bumps. Given the recent release (v0.42.0 and v0.42.1) let me know if you need help with the various semver version updates.
Hey @mxinden can you share your upgrade version tools? |
Version upgrades have been done via #2469, thus only the normal changelog entries are needed here. (The version tool is a VERY hacky Python script written by a total Python novice (me). I am not sure it is yet ready to be seen by other human beings :D ) |
Grand, I'll add the Changelog entries! |
Thanks. Can you add an entry for |
done! Ty @mxinden |
Merge needs to incorporate #2076 which is still using the old methods. Could you incorporate that @divagant-martian? Sorry for the trouble. |
@mxinden |
Oh, my bad. I am not a good rust-libp2p citizen. No need to add an entry for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clean up!
Co-authored-by: Max Inden <mail@max-inden.de>
Addresses #2434
inject_connection_established
inject_connected
inject_connection_closed
inject_disconnected
I'll leave the changelogs for later to avoid cluttering the diff for review.
In an attempt to not interfere with the logic of the protocols I left (for now) a TODO note in the autonat behaviour regarding a mapping that seems to never be cleared