Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protocols/gossipsub: Emit gossip of all non empty topics #2481

Merged
merged 3 commits into from
Feb 7, 2022
Merged

protocols/gossipsub: Emit gossip of all non empty topics #2481

merged 3 commits into from
Feb 7, 2022

Conversation

divagant-martian
Copy link
Contributor

tiny censoring bug in gossipsub. When a topic had no messages to gossip about, emit_gossip was returning early

AgeManning
AgeManning approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Good catch!

@mxinden mxinden changed the title emit gossip of all non empty topics protocols/gossipsub: Emit gossip of all non empty topics Feb 7, 2022
@mxinden mxinden merged commit 78f5981 into libp2p:master Feb 7, 2022
@mxinden
Copy link
Member

mxinden commented Feb 7, 2022

🚀 thanks!

Let me know in case you need a release with this included sometime soon. I also plan to release v0.43.0 in the next couple of weeks.

@AgeManning AgeManning deleted the tiny-censoring-bug branch November 29, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgeManning AgeManning AgeManning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@divagant-martian @mxinden @AgeManning