protocols/gossipsub: Allow score buckets to be set by the user and/or adjusted from the scoring thresholds #2595
Conversation
| /// Create buckets for the score histograms based on score thresholds. | ||
| pub fn buckets_using_scoring_thresholds(&mut self, params: &crate::PeerScoreThresholds) { | ||
| self.score_buckets = vec
There was a problem hiding this comment.
I am not sure how valuable values calculated based on the bucket values are if the buckets themselves don't follow some consistent distribution. Would it not make sense to take the smallest of all the values and do an exponential distribution to the max value (100.0)?
There was a problem hiding this comment.
You probably know best from your current measurements. How well does the histogram mirror real world values?
There was a problem hiding this comment.
The value here is to understand how often nodes are treated in a special way because they have passed the thresholds, more than to understand the distribution of scores itself. In a way is more a measure of network health/score param behaviour than a measure of the scores
mxinden
changed the title
Moves the score buckets to the metrics configuration, setting the same defaults as what we had but also allowing the user to pass a reference to the score thresholds to create them from that. Having them in the config also allows users to set them directly