-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swarm/: Rename references of protocol handler to connection handler #2640
Conversation
Thanks @maschad! |
Definitely! Will do. |
I've updated the other requested references, happy to hear any further feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the follow up @maschad! One more nit, otherwise this is good from my side.
e2fd6f2
to
2e331f9
Compare
No need to force-push. We squash pull requests in the end. |
Noted @mxinden |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks @maschad.
Just missing:
- Minor version bump over
swarm-derive
- Changelog entry on
swarm-derive
andswarm
.
…ggleIntoProtoHandler
2e331f9
to
0b50a54
Compare
Thanks for the review @mxinden . I have made the relevant adjustments. |
🙏 |
Description
Renames old references to protocol handler to the more appropriate connection handler
Links to any relevant issues
Closes #2637
Open Questions
Change checklist