Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swarm/: Rename references of protocol handler to connection handler #2640

Merged
merged 7 commits into from
May 18, 2022

Conversation

maschad
Copy link
Member

@maschad maschad commented May 11, 2022

Description

Renames old references to protocol handler to the more appropriate connection handler

Links to any relevant issues

Closes #2637

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@elenaf9
Copy link
Contributor

elenaf9 commented May 11, 2022

Thanks @maschad!
I think in some places the generics are also still called TProtoHandler (e.g. in swarm/connection/HandlerWarpper). Mind renaming those as well to TConnHandler or something like that?

@maschad
Copy link
Member Author

maschad commented May 11, 2022

Thanks @maschad!
I think in some places the generics are also still called TProtoHandler (e.g. in swarm/connection/HandlerWarpper). Mind renaming those as well to TConnHandler or something like that?

Definitely! Will do.

@maschad
Copy link
Member Author

maschad commented May 11, 2022

Thanks @maschad! I think in some places the generics are also still called TProtoHandler (e.g. in swarm/connection/HandlerWarpper). Mind renaming those as well to TConnHandler or something like that?

I've updated the other requested references, happy to hear any further feedback.

Copy link
Contributor

@elenaf9 elenaf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the follow up @maschad! One more nit, otherwise this is good from my side.

swarm-derive/src/lib.rs Outdated Show resolved Hide resolved
@maschad maschad force-pushed the replace-protocol-handler branch 3 times, most recently from e2fd6f2 to 2e331f9 Compare May 12, 2022 14:48
@mxinden
Copy link
Member

mxinden commented May 14, 2022

@maschad maschad force-pushed the replace-protocol-handler branch from e2fd6f2 to 2e331f9 2 days ago

No need to force-push. We squash pull requests in the end.

@maschad
Copy link
Member Author

maschad commented May 14, 2022

Noted @mxinden

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @maschad.

Just missing:

  • Minor version bump over swarm-derive
  • Changelog entry on swarm-derive and swarm.

@maschad
Copy link
Member Author

maschad commented May 16, 2022

Thanks for the review @mxinden . I have made the relevant adjustments.

swarm-derive/CHANGELOG.md Outdated Show resolved Hide resolved
swarm-derive/CHANGELOG.md Outdated Show resolved Hide resolved
@mxinden mxinden merged commit d97893d into libp2p:master May 18, 2022
@mxinden
Copy link
Member

mxinden commented May 18, 2022

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

swarm-derive/: Replace mentions of ProtocolsHandler with ConnectionHandler
3 participants