core/muxing: Remove the StreamMuxer::flush_all function
#2669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`libp2p-core` provides the `StreamMuxer` abstraction so it can provide functionality that abstracts over this trait. We never use the `flush_all` function as part of our abstractions. No one else is going to use it so we can remove it from the abstraction.
27 tasks
thomaseizinger
changed the title
StreamMuxer::flush_all functionStreamMuxer::flush_all function
mxinden
reviewed
May 29, 2022
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
libp2p-coreprovides theStreamMuxerabstraction so it can providefunctionality that abstracts over this trait.
We never use the
flush_allfunction as part of our abstractions.No one else is going to use it so we can remove it from the abstraction.
Links to any relevant issues
StreamMuxertrait #2648.Open Questions
Change checklist