core/muxing: Introduce StreamMuxerEvent::map_inbound_stream
#2691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the noise within core/src/either.rs and will reduce the diff in libp2p#2648.
mxinden
reviewed
Jun 8, 2022
mxinden
reviewed
Jun 8, 2022
core/src/muxing.rs
Outdated
| @@ -241,6 +241,16 @@ impl<T> StreamMuxerEvent<T> { | |||
| None | |||
| } | |||
| } | |||
|
|
|||
| /// Map the stream within [`StreamMuxerEvent::InboundSubstream`] to a new type. | |||
| pub fn map_stream<O>(self, map: impl FnOnce(T) -> O) -> StreamMuxerEvent<O> { | |||
There was a problem hiding this comment.
Suggested change
| pub fn map_stream<O>(self, map: impl FnOnce(T) -> O) -> StreamMuxerEvent<O> { | |
| pub fn map_inbound_stream<O>(self, map: impl FnOnce(T) -> O) -> StreamMuxerEvent<O> { |
Just to avoid the confusion of folks expecting the StreamMuxerEvent to somehow contain both inbound and outbound streams. What do you think?
There was a problem hiding this comment.
It will contain both streams once #2648 is merged. If we do this rename now, I will have to rename it again :)
What do you prefer?
There was a problem hiding this comment.
Though extra work, I would prefer the rename. That way I can merge to master already, keeping master clean. The two pull requests might not be released in the same release. Mind doing the change (twice)? 😇
27 tasks
thomaseizinger
changed the title
StreamMuxerEvent::map_streamStreamMuxerEvent::map_inbound_stream
mxinden
approved these changes
Jun 15, 2022
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reduces the noise within core/src/either.rs.
Links to any relevant issues
Will reduce diff in #2648.
Open Questions
Change checklist