Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

muxers/mplex: Implement AsyncRead and AsyncWrite for Substream #2705

Commits on Jun 15, 2022

  1. muxers/mplex: Implement AsyncRead and AsyncWrite for Substream

    This aligns the public API of the `libp2p-mplex` module with the one
    from `libp2p-yamux`. This change has two benefits:
    
    1. For standalone users of `libp2p-mplex`, the substreams itself are
    now useful, similar to `libp2p-yamux` and don't necessarily need to
    be polled via the `StreamMuxer`. The `StreamMuxer` only forwards to
    the `Async{Read,Write}` implementations.
    
    2. This will reduce the diff of libp2p#2648 because we can chunk the one
    giant commit into smaller atomic ones.
    thomaseizinger committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    0c7c309 View commit details
    Browse the repository at this point in the history