protocols/identify: Extend log message on second identify push #2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print remote peer ID when seeing a second identify push stream coming in.
|
//CC @BigLep this is the last pull request, making sure log messages on exceeding limits are useful. |
thomaseizinger
approved these changes
Jun 24, 2022
| @@ -120,8 +149,9 @@ impl ConnectionHandler for IdentifyHandler { | |||
| EitherOutput::Second(fut) => { | |||
| if self.inbound_identify_push.replace(fut).is_some() { | |||
| warn!( | |||
There was a problem hiding this comment.
Unrelated: We might want to upgrade to tracing at some point so we can emit these values in a structured way.
Or we wait until log has a structured key-value support.
There was a problem hiding this comment.
👍 for structured logging, though not something I will focus on any time soon. Don't have an opinion on crates providing structured logging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Print remote peer ID when seeing a second identify push stream coming in.
Most of the changes are needed to make
IdentifyHandleraware of the peer ID of its remote.Links to any relevant issues
Open Questions
Change checklist