Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocols/gossipsub: Fix a typo in error message #2739

Merged
merged 2 commits into from
Jun 30, 2022

Conversation

ackintosh
Copy link
Contributor

Description

Fixed a typo in the error message. 😃

Please let me know if a changelog entry is needed for this pull request.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, changelog not required for this, thank you!

Comment on lines 1529 to 1532
.is_err()
{
error!("Failed to send graft. Message too large");
error!("Failed to send PRUNE. Message too large");
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "Message to large" really the only failure mode here? That is not obvious from just checking is_err?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. 💡 I'll update this.

@ackintosh
Copy link
Contributor Author

@thomaseizinger Thank you for your review! I have updated this, please have another look when you have time.

Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a good improvement!

@thomaseizinger thomaseizinger merged commit 748588e into libp2p:master Jun 30, 2022
@ackintosh ackintosh deleted the fix-typo-error-message branch June 30, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants