.cargo: check all features in custom-clippy

[elenaf9]

Description

Our custom-clippy currently just runs clippy with the default features. The result of this is that a) not all packages are checked, and b) all features in those packages are disabled. This caused issues like #2770 and #2737.
Extended it now to check all features.

Depends on:

• core/identity/ecdsa: fix clippy::op-ref, clippy::needless-borrow #2770
• dcutr: fix clippy lints #2772
• misc/metrics: fix clippy::assign-op-pattern #2773
• transports/tcp: fix clippy::from-over-into #2774

[elenaf9]

As an aside: while reading through the cargo book i stumbled across the following note on rust workspaces: https://doc.rust-lang.org/cargo/reference/workspaces.html#the-workspace-section

All path dependencies residing in the workspace directory automatically become members.

Apart from some of the packages in /misc, I think all of our [workspace] members that we currently explicitly list are already path dependencies. I don't really have a strong opinion in this, but theoretically we could remove them from the members list, which makes it one place less to worry about when adding a new package. Wdyt @thomaseizinger @mxinden? Are there any other packages in our workspace that are not path dependencies?

[thomaseizinger]

Interesting, I didn't know that. Happy to remove them from the members list then :)

[mxinden]

🙏 Thanks for investigating.

[mxinden]

@elenaf9 would you mind addressing the remaining clippy failures?

[elenaf9]

@elenaf9 would you mind addressing the remaining clippy failures?

@mxinden #2772 🙂

[mxinden]

Oh, sorry for missing #2772 @elenaf9.