protocols/: Remove passing default variant to WithPeerId::condition

[K0UR05H]

Description

Since PeerCondition::Disconnected is the default variant and is used here, there is no need to pass it again to WithPeerId::condition.

Links to any relevant issues

Open Questions

Change checklist

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• A changelog entry has been made in the appropriate crates

[elenaf9]

Thank you for contributing @k0ur0x!
I am not sure whether it's a good idea to remove the explicit .condition(dial_opts::PeerCondition::Disconnected). Being explicit about things imo generally makes maintaining the code easier. It saves trouble in the future when you look back at some code wondering "Was using the default value a conscious choice?". Especially if we ever decided to change the default value.

[mxinden]

Thanks for the contribution @k0ur0x.

I don't have a strong opinion here.

I think the choice of using PeerCondition::Disconnected is reasonably obvious in each of these cases, thus I don't think there is any need to be explicit and thus I think we can just depend on the default behavior as proposed in this pull request.

[elenaf9]

I don't have a strong opinion here.

I think the choice of using PeerCondition::Disconnected is reasonably obvious in each of these cases, thus I don't think there is any need to be explicit and thus I think we can just depend on the default behavior as proposed in this pull request.

Makes sense. No strong opinion on my side either.