Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc/multistream-select: Replace msg.get(0) with msg.first() #2816

Merged
merged 1 commit into from
Aug 13, 2022

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Aug 13, 2022

Description

Fix clippy warning:

error: accessing first element with `msg.get(0)`                                                                                              
   --> misc/multistream-select/src/protocol.rs:182:12                                                                                         
    |                                                                                                                                         
182 |         if msg.get(0) == Some(&b'/')                                                                                                    
    |            ^^^^^^^^^^ help: try: `msg.first()`                                                                                          
    |                                                                                                                                         
    = note: `-D clippy::get-first` implied by `-D warnings`                                                                                   
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first                                 

Links to any relevant issues

Fails CI on #2786

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@mxinden mxinden merged commit 0a01c81 into libp2p:master Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants