protocols/gossipsub: Allow publishing to anything that implements Into<TopicHash>
#2862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for contributing!
I think this is okay but I'd like to also have @mxinden 's opinion on this.
Can you also make a changelog entry please? (Depending on which API we settle on of course.)
protocols/gossipsub/src/behaviour.rs
Outdated
| @@ -586,20 +586,29 @@ where | |||
| Ok(true) | |||
| } | |||
|
|
|||
| /// Publishes a message with multiple topics to the network. | |||
| /// Publishes a message to a topic in the network. | |||
| pub fn publish<H: Hasher>( | |||
| &mut self, | |||
| topic: Topic<H>, | |||
There was a problem hiding this comment.
Suggested change
| topic: Topic<H>, | |
| topic: impl Into<TopicHash>, |
Would it make sense to generalise the API to this instead of duplicating the function?
This would allow you to pass either a topic or a topic hash.
There was a problem hiding this comment.
cc @AgeManning What do you think of this API change?
There was a problem hiding this comment.
I like this approach, as it extends the existing API without overcomplicating it. Changed this PR to match this comment and added a changelog item.
Modify publish() signature to use impl Into<TopicHash>.
thomaseizinger
changed the title
Into<TopicHash>
thomaseizinger
approved these changes
Sep 4, 2022
AgeManning
approved these changes
Sep 5, 2022
mxinden
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I store TopicHashes for gossipsub topics in my app for performance reasons. And rehashing Topics every time I want to publish seems redundant to me.
Change checklist