protocols/noise: Introduce NoiseAuthenticated::xx constructor with X25519 DH key exchange
#2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the most common way of doing noise in libp2p and thus deserves a convenience ctor.
thomaseizinger
changed the title
NoiseAuthenticated::xx ctor with X25519 DH key exchangeNoiseAuthenticated::xx constructor with X25519 DH key exchange
4 tasks
mxinden
approved these changes
Sep 15, 2022
Co-authored-by: Max Inden <mail@max-inden.de>
|
Thanks @mxinden! |
|
You forgot to add a CHANGELOG entry |
There is one for |
|
I thought there should be an entry in the root CHANGELOG.md |
Yep, that is true, thank you! |
4 tasks
|
See #2912. |
4 tasks
mxinden
added a commit
to mxinden/rust-libp2p
that referenced
this pull request
Sep 29, 2022
We support two versions of the Noise XX handshake with X25519, but only one of them is compliant with the specification and thus compliant with other implementations. We should always default to the spec compliant handshake. Fixes bug introduced in libp2p#2887
4 tasks
mxinden
added a commit
that referenced
this pull request
Sep 29, 2022
We support two versions of the Noise XX handshake with X25519, but only one of them is compliant with the specification and thus compliant with other implementations. We should always default to the spec compliant handshake. Fixes bug introduced in #2887
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the most common way of doing noise in libp2p and thus deserves a convenience ctor. I came across this while working on #2884, trying to reduce the noise (no pun intended) in setting up swarms for testing.
Links to any relevant issues
Open Questions
Change checklist
- [ ] I have added tests that prove my fix is effective or that my feature works