Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): subscribe to topic in chat-tokio #3296

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

elenaf9
Copy link
Contributor

@elenaf9 elenaf9 commented Jan 2, 2023

Description

With #3097, subscribing to the floodsub topic in examples/chat-tokio.rs was removed. I assume this was unintentional (cc @umgefahren), so this PR adds it back.

Links to any relevant issues

Most likely the reason why the example did not work in #3217.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Elena, great catch!

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mxinden mxinden added the send-it label Jan 4, 2023
@mxinden
Copy link
Member

mxinden commented Jan 4, 2023

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jan 4, 2023

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit bda1420 into libp2p:master Jan 4, 2023
@elenaf9 elenaf9 deleted the fix-chat-tokio branch January 4, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants