Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tcp): Rename TcpListenStream to ListenStream #3324

Merged
merged 1 commit into from
Jan 17, 2023
Merged

refactor(tcp): Rename TcpListenStream to ListenStream #3324

merged 1 commit into from
Jan 17, 2023

Conversation

jxs
Copy link
Member

@jxs jxs commented Jan 13, 2023 •
edited by thomaseizinger
Loading

Description

Notes

stumbled upon this while reading the tcp transport implementation, probably was left out on #2961

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

mxinden
mxinden approved these changes Jan 15, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@thomaseizinger thomaseizinger mentioned this pull request Jan 16, 2023
Merged
@thomaseizinger
Copy link
Contributor

thomaseizinger commented Jan 17, 2023 •
edited
Loading

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jan 17, 2023

Sorry but I didn't understand the command. Please consult the commands documentation 📚.

@mergify
Copy link
Contributor

mergify bot commented Jan 17, 2023

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit 735945d into libp2p:master Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jxs @thomaseizinger @mxinden