feat: introduce libp2p-connection-limits connection management module
#3386
Conversation
…p into feat-kademlia/use-gats
…o-connection-handler
This is handled by `DialError` and `ListenFailure`.
|
Use the new |
To actually do this, I had to move |
Thanks `cargo semver-checks`!
thomaseizinger
changed the title
NetworkBehaviourlibp2p-connection-limits connection management module
|
This pull request has merge conflicts. Could you please resolve them @thomaseizinger? 🙏 |
| } | ||
| } | ||
|
|
||
| impl NetworkBehaviour for Behaviour { |
There was a problem hiding this comment.
We overload the string protocol with many meanings. The main one for in relation with the protocols/ folder being that all things in their implement NetworkBehaviour.
Given that libp2p_connection_limits::Behaviour implements NetworkBehaviour I think it should live in protocols/.
There was a problem hiding this comment.
The main one for in relation with the
protocols/folder being that all things in their implementNetworkBehaviour.
We already have multiple utilities in libp2p-swarm that implement NetworkBehaviour without living under protocols/. To me, a libp2p "protocol" must have some form of network communication. This one here uses the dummy::ConnectionHandler so it will never perform any IO, hence I placed it in misc/.
There was a problem hiding this comment.
As you know, I am not a massive fan of the directory structure anyway but putting this one into protocols/ actually feels wrong.
Protocols should be present on the wire, this one here is just an internal rust-libp2p concept.
misc/ is not a great name either because everything fits the description :)
With libp2p-identity merged, I'd like to push for the next step towards moving around the crate boundaries. Once we have all that in place, I think it makes sense to think about new directories.
Thoughts?
| @@ -0,0 +1,3 @@ | |||
| # 0.1.0 - unreleased | |||
There was a problem hiding this comment.
Nit pick, we recommend the below. I don't care which syntax we use, as long as we stay consistent. Makes my life creating the docs(CHANGELOG): Prepare xxx a bit easier.
| # 0.1.0 - unreleased | |
| # 0.1.0 [unreleased] |
https://github.com/libp2p/rust-libp2p/blob/master/docs/release.md#development-between-releases
There was a problem hiding this comment.
[unreleased] is a link reference that doesn't point to anything so I stopped using that. Can update the docs if you agree.
There was a problem hiding this comment.
Never thought about that. Yes, patch would be appreciated.
There was a problem hiding this comment.
PR here: #3615
|
I am removing the dependency on #3615. Based on #3386 (comment), I am assuming that @mxinden is in favor of the new changelog syntax so I am using this here and we can iterate on the exact wording in #3615 after that. |
Description
This patch deprecates the existing connection limits within
Swarmand uses the newNetworkBehaviourAPIs to implement it as a plugin instead.Related #2824.
Notes
This is a WIP in that it still needs tests but overall, this is pretty much what it will look like.Links to any relevant issues
Open Questions
Change checklist