Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(uds): Bump version #3502

Merged
merged 1 commit into from
Feb 24, 2023
Merged

fix(uds): Bump version #3502

merged 1 commit into from
Feb 24, 2023

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Feb 24, 2023

Description

#3196 forgot to bump libp2p-uds. libp2p-uds was updated to libp2p-core v0.39.0 thus requiring the version bump.

This has happened before, see #2720.

Notes

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@mxinden
fix(uds): Bump version
7c46e6e 
libp2p#3196 forgot to bump `libp2p-uds`. `libp2p-uds` was
updated to `libp2p-core` `v0.39.0` thus requiring the version bump.

This has happened before, see libp2p#2720.
mxinden added a commit to mxinden/rust-libp2p that referenced this pull request Feb 24, 2023
@mxinden
refactor(uds): Move WASM feature flagging to root Cargo.toml
f9f8df1 
Crates that don't compile for WASM are feature flagged in the root `Cargo.toml`, expcept for
`libp2p-uds`. This commit removes the inconsistency.

As a side-effect, this might help prevent bugs like libp2p#3502
going forward.
@mxinden mxinden mentioned this pull request Feb 24, 2023
Merged
4 tasks
@mxinden
Copy link
Member Author

mxinden commented Feb 24, 2023

See #3503 for a "more" long term fix.

@mergify mergify bot merged commit 1a9cf4f into libp2p:master Feb 24, 2023
mergify bot pushed a commit that referenced this pull request Mar 7, 2023
@mxinden
refactor(uds): Move WASM feature flagging to root Cargo.toml
2c10cd8 
Crates that don't compile for WASM are feature flagged in the root `Cargo.toml`, expcept for `libp2p-uds`. This commit removes the inconsistency.

As a side-effect, this might help prevent bugs like #3502 going forward.

Pull-Request: #3503.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxinden @thomaseizinger