deps: bump clap from 4.2.1 to 4.2.4 #3808
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [clap](https://github.com/clap-rs/clap) from 4.2.1 to 4.2.4. - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](clap-rs/clap@v4.2.1...v4.2.4) --- updated-dependencies: - dependency-name: clap dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
| @@ -13,7 +13,7 @@ categories = ["network-programming", "asynchronous"] | |||
| [dependencies] | |||
| anyhow = "1" | |||
| async-std = { version = "1.9.0", features = ["attributes"] } | |||
| clap = { version = "4.2.1", features = ["derive"] } | |||
| clap = { version = "4.2.4", features = ["derive"] } | |||
There was a problem hiding this comment.
This being part of the regular dependencies adds a lot of code for users that activate the perf feature.
It is for testing only but I think I'd still feel better if these dependencies wouldn't be part of our normal dependency tree.
Not sure if we've previously discussed this but perhaps we should remove perf from our optional libp2p dependencies such that it doesn't show up as part of full?
cc @mxinden
There was a problem hiding this comment.
Discussed it here #3508 (comment), though from a different perspective.
I don't think removing-from-full is worth the inconsistency it introduces. Users should not be surprised that compile times are high when they use full. In terms of CI speed, we would need to build clap either way.
|
A newer version of clap exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Bumps clap from 4.2.1 to 4.2.4.
Release notes
Sourced from clap's releases.
Changelog
Sourced from clap's changelog.
Commits
60c8c3fchore: Releasee9b4c47docs: Update changeloge429a9eMerge pull request #4845 from epage/color1ca073fdocs(help): Fill in styles docs6d5aaaefeat(help): Allow access to current Stylesb99c50fchore: Release3f46258docs: Update changelogb0e0c59Merge pull request #4843 from epage/stylecbea23estyle: Make clippy happy5ca3b2frefactor(help): Shrink binary sizeYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)