Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(swarm): rename Custom variant to NotifyBehaviour #3955

Merged
merged 3 commits into from
May 16, 2023
Merged

feat(swarm): rename Custom variant to NotifyBehaviour #3955

merged 3 commits into from
May 16, 2023

Conversation

tcoratger
Copy link
Contributor

@tcoratger tcoratger commented May 16, 2023 •
edited by thomaseizinger
Loading

Description

Rename ConnectionHandlerEvent::Custom to ConnectionHandlerEvent::NotifyBehaviour.

Related #3848.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@tcoratger tcoratger mentioned this pull request May 16, 2023
Merged
3 tasks
@thomaseizinger thomaseizinger changed the title feat(swarm): ConnectionHandlerEvent Custom to NotifyBehaviour feat(swarm): rename Custom variant to NotifyBehaviour May 16, 2023
thomaseizinger
thomaseizinger approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for the quick PR!

@mergify mergify bot merged commit 9f3c851 into libp2p:master May 16, 2023
@tcoratger tcoratger deleted the connectionhandler-custom branch May 16, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcoratger @thomaseizinger