feat(core): remove deprecated identity module
#4040
Conversation
thomaseizinger
added
send-it
trivial
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
|
This is currently failing because we made some errors in the previous release of Anyway, this will pass once we upgrade to the latest |
Actually, I found a way to temporarily unblock this. We just need to activate a feature-flag that very likely will be activated anywhere somewhere in the dependency graph. |
| @@ -39,11 +39,9 @@ libp2p-mplex = { workspace = true } | |||
| libp2p-noise = { workspace = true } | |||
| multihash = { version = "0.17.0", default-features = false, features = ["arb"] } | |||
| quickcheck = { workspace = true } | |||
| libp2p-identity = { workspace = true, features = ["ed25519"] } | |||
There was a problem hiding this comment.
Why was libp2p-identity added here as a dev-dependency even though it is already included as a dependency @thomaseizinger?
There was a problem hiding this comment.
Originally to activate a feature but that probably became unnecessary in an iteration or something :)
There was a problem hiding this comment.
See #4040 (comment).
There was a problem hiding this comment.
Thus do I understand correctly that this line is no longer needed from now on @thomaseizinger?
There was a problem hiding this comment.
I think the line is needed but I think the feature can be removed!
Description
Related: #3647.
Notes & open questions
Change checklist