Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): call Swarm::add_external_address in dcutr and relay #4052

Merged
merged 2 commits into from
Jun 9, 2023
Merged

fix(examples): call Swarm::add_external_address in dcutr and relay #4052

merged 2 commits into from
Jun 9, 2023

Commits on Jun 9, 2023

  1. fix(examples): call Swarm::add_external_address in dcutr and relay 

    > Observed addresses (aka. external address candidates) of the local node, reported by a remote node
> via `libp2p-identify`, are no longer automatically considered confirmed external addresses, in
> other words they are no longer trusted by default. Instead users need to confirm the reported
> observed address either manually, or by using `libp2p-autonat`. In trusted environments users can
> simply extract observed addresses from a `libp2p-identify::Event::Received { info:
> libp2p_identify::Info { observed_addr }}` and confirm them via `Swarm::add_external_address`.

Follow-up to libp2p#3954.
    @mxinden
    mxinden committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    5fc50d0 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @mxinden
    mxinden authored Jun 9, 2023
    Configuration menu
    Copy the full SHA
    b214bea View commit details
    Browse the repository at this point in the history