fix(multistream-select): remove cyclic dependency to libp2p-core
#4090
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All of the removed
dev-dependencies
are only for testing the upgrade procedure inlibp2p-core
. Ironically, this test does not use a single API ofmultistream-select
. Thus, this test is simply misplaced in this crate. If we wanted to retain it, it should probably go intolibp2p
itself as that one already depends on all required crates.Related: #4053.
Notes & open questions
Change checklist