-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(server): filter out /quic
in favor of /quic-v1
#4467
Merged
Merged
Commits on Sep 7, 2023
-
fix(server): filter out
/quic
in favor of/quic-v1
Configuration files generated by Kubo <= v0.22 list both `/quic` and `/quic-v1` listen addresses with the same UDP port. Given that we enable draft-29, the two addresses are treated the same by rust-libp2p's QUIC implementation. Though calling `listen_on` with both results in an "Address already in use" error by the OS on the second call. To prevent this from happening filter out `/quic` addresses in favor of `/quic-v1`.
Configuration menu - View commit details
-
Copy full SHA for c5d5505 - Browse repository at this point
Copy the full SHA c5d5505View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40f7935 - Browse repository at this point
Copy the full SHA 40f7935View commit details
Commits on Sep 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 93564ba - Browse repository at this point
Copy the full SHA 93564baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 41991d9 - Browse repository at this point
Copy the full SHA 41991d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for beb7c27 - Browse repository at this point
Copy the full SHA beb7c27View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba00657 - Browse repository at this point
Copy the full SHA ba00657View commit details -
Configuration menu - View commit details
-
Copy full SHA for 295146c - Browse repository at this point
Copy the full SHA 295146cView commit details
Commits on Sep 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7e21f9b - Browse repository at this point
Copy the full SHA 7e21f9bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.