feat(swarm): add `#[non_exhaustive]` to key enums #4581

dhuseby · 2023-10-02T20:41:52Z

Description

Add #[non_exhaustive] to the following enums so that future additions don't cause breaking changes in downstream client code: FromSwarm, ToSwarm, SwarmEvent, ConnectionHandlerEvent, ConnectionEvent.

Related: #4543.

Notes & open questions

This refactored a number of examples and protocols to have a default option when doing a match against these enums.

Change checklist

I have performed a self-review of my own code
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
A changelog entry has been made in the appropriate crates

Signed-off-by: Dave Huseby <dwh@linuxprogrammer.org>

thomaseizinger

Thanks for getting this started!

misc/allow-block-list/src/lib.rs

swarm/CHANGELOG.md

swarm/tests/swarm_derive.rs

protocols/rendezvous/src/client.rs

Co-authored-by: Thomas Eizinger <thomas@eizinger.io>

…add-non_exhaustive

protocols/rendezvous/src/server.rs

Signed-off-by: Dave Huseby <dwh@linuxprogrammer.org>

swarm-derive/src/lib.rs

misc/allow-block-list/src/lib.rs

mergify · 2023-10-20T06:32:13Z

This pull request has merge conflicts. Could you please resolve them @dhuseby? 🙏

Signed-off-by: Dave Huseby <dwh@linuxprogrammer.org>

thomaseizinger

A few more things, otherwise LGTM!

protocols/rendezvous/src/client.rs

swarm-derive/src/lib.rs

swarm-derive/Cargo.toml

swarm/Cargo.toml

Signed-off-by: Dave Huseby <dwh@linuxprogrammer.org>

mxinden

Looking good to me overall. Suggestion from @thomaseizinger on map_in sounds worth blocking on.

Cargo.toml

mergify · 2023-10-31T13:21:52Z

This pull request has merge conflicts. Could you please resolve them @dhuseby? 🙏

dhuseby · 2023-10-31T17:48:41Z

@mxinden and @thomaseizinger should we consider adding #[non_exhaustive] to any of the error enums in swarm/src/lib.rs? How often do we add new errors? I'm looking at:

DialError:

rust-libp2p/swarm/src/lib.rs

Line 1489 in d0f62e9

pub enum DialError {
ListenError:

rust-libp2p/swarm/src/lib.rs

Line 1591 in d0f62e9

pub enum ListenError {

add a warning to future developers about bumping the version. Co-authored-by: Max Inden <mail@max-inden.de>

.github/workflows/ci.yml

This reverts commit 344e012.

This reverts commit e6aff9f.

thomaseizinger · 2023-11-02T06:18:48Z

CI should hopefully pass now. @mxinden please review :)

Signed-off-by: Dave Huseby <dwh@linuxprogrammer.org>

…add-non_exhaustive

Signed-off-by: Dave Huseby <dwh@linuxprogrammer.org>

mxinden

Great to see this landing.

Thanks @dhuseby for the initial suggestion.

Thanks @dhuseby and @thomaseizinger for the implementation.

dhuseby · 2023-11-02T21:38:22Z

Great to see this landing.

Thank you @mxinden for you reviews!

nazar-pc · 2023-11-08T22:50:46Z

This is actually an annoying change for our request-response wrapper where we have kind of a factory protocol that creates other protocols internally and now that enum is non-exhaustive we have no compile-time guarantees about what variants are there, so during upgrade we can forget to forward some.

thomaseizinger · 2023-11-09T00:44:18Z

If you are okay with running lints on nightly, you could make use of rust-lang/rust#89554.

thomaseizinger · 2023-11-09T00:46:25Z

For ToSwarm, I'd recommend to use the various map functions like map_in and map_out. Delegating to those will ensure you are exhaustively matching because they are defined in libp2p-swarm.

For FromSwarm, you should be able to forward the entire message without matching on it.

nazar-pc · 2023-11-09T00:47:39Z

Didn't know about map functions, might be helpful here, thanks!

thomaseizinger · 2023-11-09T00:48:20Z

Didn't know about map functions, might be helpful here, thanks!

That is how we solve this issue for the custom-derive which also has to generate code that lives outside of libp2p-swarm but should always match exhaustively.

thomaseizinger · 2023-11-09T01:12:19Z

I just opened #4825 which should help as well.

We can make `FromSwarm` implement `Copy` and `Close` which makes it much easier to a) generate code in `libp2p-swarm-derive` b) manually wrap a `NetworkBehaviour` Previously, we couldn't do this because `ConnectionClosed` would have a `handler` field that cannot be cloned / copied. Related: #4076. Related: #4581. Pull-Request: #4825.

* ci: unset `RUSTFLAGS` value in semver job Don't fail semver-checking if a dependency version has warnings, such as deprecation notices. Related: libp2p#4932 (comment). Related: obi1kenobi/cargo-semver-checks#589. Pull-Request: libp2p#4942. * deps(webrtc): bump alpha versions Bumps versions of `libp2p-webrtc` and `libp2p-webrtc-websys` up one minor version. Fixes: libp2p#4953. Pull-Request: libp2p#4959. * feat(request-response): derive `PartialOrd`,`Ord` for `{Out,In}RequestId` Pull-Request: libp2p#4956. * refactor(connection-limits): make `check_limit` a free-function Pull-Request: libp2p#4958. * chore(webrtc-utils): bump version to allow for new release We didn't bump this crate's version despite it depending on `libp2p_noise`. As such, we can't release `libp2p-webrtc-websys` at the moment because it needs a new release of this crate. Pull-Request: libp2p#4968. * feat(webrtc-websys): hide `libp2p_noise` from the public API Currently, `libp2p-webrtc-websys` exposes the `libp2p_noise` dependency in its public API. It should really be a private dependency of the crate. By wrapping it in a new-type, we can achieve this. Pull-Request: libp2p#4969. * fix(kad): iterator progress to be decided by any of new peers Pull-Request: libp2p#4932. * chore(quic): set `max_idle_timeout` to quinn default timeout Resolves libp2p#4917. Pull-Request: libp2p#4965. * feat(core): impl Display on ListenerId Fixes: libp2p#4935. Pull-Request: libp2p#4936. * feat(server): support websocket Pull-Request: libp2p#4937. * feat(swarm): implement `Copy` and `Clone` for `FromSwarm` We can make `FromSwarm` implement `Copy` and `Close` which makes it much easier to a) generate code in `libp2p-swarm-derive` b) manually wrap a `NetworkBehaviour` Previously, we couldn't do this because `ConnectionClosed` would have a `handler` field that cannot be cloned / copied. Related: libp2p#4076. Related: libp2p#4581. Pull-Request: libp2p#4825. * deps: bump wasm-bindgen-futures from 0.4.38 to 0.4.39 Pull-Request: libp2p#4946. * feat(connection-limit): add function to mutate `ConnectionLimits` Resolves: libp2p#4826. Pull-Request: libp2p#4964. * deps: bump web-sys from 0.3.65 to 0.3.66 Pull-Request: libp2p#4976. * deps: bump wasm-bindgen-test from 0.3.38 to 0.3.39 Pull-Request: libp2p#4975. * fix(kad): don't assume `QuerId`s are unique We mistakenly assumed that `QueryId`s are unique in that, only a single request will be emitted per `QueryId`. This is wrong. A bootstrap for example will issue multiple requests as part of the same `QueryId`. Thus, we cannot use the `QueryId` as a key for the `FuturesMap`. Instead, we use a `FuturesTupleSet` to associate the `QueryId` with the in-flight request. Related: libp2p#4901. Resolves: libp2p#4948. Pull-Request: libp2p#4971. * fix(webrtc example): clarify idle connection timeout When I ran the `example/browser-webrtc` example I discovered it would break after a ping or two. The `Ping` idle timeout needed to be extended, on both the server and the wasm client, which is what this PR fixes. I also added a small note to the README about ensuring `wasm-pack` is install for the users who are new to the ecosystem. Fixes: libp2p#4950. Pull-Request: libp2p#4966. * docs(examples/readme): fix broken link Related: libp2p#3536. Pull-Request: libp2p#4984. * feat(yamux): auto-tune (dynamic) stream receive window libp2p/rust-yamux#176 enables auto-tuning for the Yamux stream receive window. While preserving small buffers on low-latency and/or low-bandwidth connections, this change allows for high-latency and/or high-bandwidth connections to exhaust the available bandwidth on a single stream. Using the [libp2p perf](https://github.com/libp2p/test-plans/blob/master/perf/README.md) benchmark tools (60ms, 10Gbit/s) shows an **improvement from 33 Mbit/s to 1.3 Gbit/s** in single stream throughput. See libp2p/rust-yamux#176 for details. To ship the above Rust Yamux change in a libp2p patch release (non-breaking), this pull request uses `yamux` `v0.13` (new version) by default and falls back to `yamux` `v0.12` (old version) when setting any configuration options. Thus default users benefit from the increased performance, while power users with custom configurations maintain the old behavior. Pull-Request: libp2p#4970. * deps: bump actions/deploy-pages from 2 to 3 Pull-Request: libp2p#4978. * deps: bump the axum group with 2 updates Pull-Request: libp2p#4943. * chore(webrtc-websys): remove unused dependencies Pull-Request: libp2p#4973. * chore(quic): fix link to PR in changelog Pull-Request: libp2p#4993. * deps: bump tokio from 1.34.0 to 1.35.0 Pull-Request: libp2p#4995. * deps: bump syn from 2.0.39 to 2.0.40 Pull-Request: libp2p#4996. * deps: bump once_cell from 1.18.0 to 1.19.0 Pull-Request: libp2p#4998. --------- Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com> Co-authored-by: Doug A <douganderson444@gmail.com> Co-authored-by: Darius Clark <dariusc93@users.noreply.github.com> Co-authored-by: zhiqiangxu <652732310@qq.com> Co-authored-by: Thomas Eizinger <thomas@eizinger.io> Co-authored-by: maqi <qi.ma@maidsafe.net> Co-authored-by: stormshield-frb <144998884+stormshield-frb@users.noreply.github.com> Co-authored-by: Max Inden <mail@max-inden.de> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: NAHO <90870942+trueNAHO@users.noreply.github.com>

* ci: unset `RUSTFLAGS` value in semver job Don't fail semver-checking if a dependency version has warnings, such as deprecation notices. Related: libp2p#4932 (comment). Related: obi1kenobi/cargo-semver-checks#589. Pull-Request: libp2p#4942. * deps(webrtc): bump alpha versions Bumps versions of `libp2p-webrtc` and `libp2p-webrtc-websys` up one minor version. Fixes: libp2p#4953. Pull-Request: libp2p#4959. * feat(request-response): derive `PartialOrd`,`Ord` for `{Out,In}RequestId` Pull-Request: libp2p#4956. * refactor(connection-limits): make `check_limit` a free-function Pull-Request: libp2p#4958. * chore(webrtc-utils): bump version to allow for new release We didn't bump this crate's version despite it depending on `libp2p_noise`. As such, we can't release `libp2p-webrtc-websys` at the moment because it needs a new release of this crate. Pull-Request: libp2p#4968. * feat(webrtc-websys): hide `libp2p_noise` from the public API Currently, `libp2p-webrtc-websys` exposes the `libp2p_noise` dependency in its public API. It should really be a private dependency of the crate. By wrapping it in a new-type, we can achieve this. Pull-Request: libp2p#4969. * fix(kad): iterator progress to be decided by any of new peers Pull-Request: libp2p#4932. * chore(quic): set `max_idle_timeout` to quinn default timeout Resolves libp2p#4917. Pull-Request: libp2p#4965. * feat(core): impl Display on ListenerId Fixes: libp2p#4935. Pull-Request: libp2p#4936. * feat(server): support websocket Pull-Request: libp2p#4937. * feat(swarm): implement `Copy` and `Clone` for `FromSwarm` We can make `FromSwarm` implement `Copy` and `Close` which makes it much easier to a) generate code in `libp2p-swarm-derive` b) manually wrap a `NetworkBehaviour` Previously, we couldn't do this because `ConnectionClosed` would have a `handler` field that cannot be cloned / copied. Related: libp2p#4076. Related: libp2p#4581. Pull-Request: libp2p#4825. * deps: bump wasm-bindgen-futures from 0.4.38 to 0.4.39 Pull-Request: libp2p#4946. * feat(connection-limit): add function to mutate `ConnectionLimits` Resolves: libp2p#4826. Pull-Request: libp2p#4964. * deps: bump web-sys from 0.3.65 to 0.3.66 Pull-Request: libp2p#4976. * deps: bump wasm-bindgen-test from 0.3.38 to 0.3.39 Pull-Request: libp2p#4975. * fix(kad): don't assume `QuerId`s are unique We mistakenly assumed that `QueryId`s are unique in that, only a single request will be emitted per `QueryId`. This is wrong. A bootstrap for example will issue multiple requests as part of the same `QueryId`. Thus, we cannot use the `QueryId` as a key for the `FuturesMap`. Instead, we use a `FuturesTupleSet` to associate the `QueryId` with the in-flight request. Related: libp2p#4901. Resolves: libp2p#4948. Pull-Request: libp2p#4971. * fix(webrtc example): clarify idle connection timeout When I ran the `example/browser-webrtc` example I discovered it would break after a ping or two. The `Ping` idle timeout needed to be extended, on both the server and the wasm client, which is what this PR fixes. I also added a small note to the README about ensuring `wasm-pack` is install for the users who are new to the ecosystem. Fixes: libp2p#4950. Pull-Request: libp2p#4966. * docs(examples/readme): fix broken link Related: libp2p#3536. Pull-Request: libp2p#4984. * feat(yamux): auto-tune (dynamic) stream receive window libp2p/rust-yamux#176 enables auto-tuning for the Yamux stream receive window. While preserving small buffers on low-latency and/or low-bandwidth connections, this change allows for high-latency and/or high-bandwidth connections to exhaust the available bandwidth on a single stream. Using the [libp2p perf](https://github.com/libp2p/test-plans/blob/master/perf/README.md) benchmark tools (60ms, 10Gbit/s) shows an **improvement from 33 Mbit/s to 1.3 Gbit/s** in single stream throughput. See libp2p/rust-yamux#176 for details. To ship the above Rust Yamux change in a libp2p patch release (non-breaking), this pull request uses `yamux` `v0.13` (new version) by default and falls back to `yamux` `v0.12` (old version) when setting any configuration options. Thus default users benefit from the increased performance, while power users with custom configurations maintain the old behavior. Pull-Request: libp2p#4970. * deps: bump actions/deploy-pages from 2 to 3 Pull-Request: libp2p#4978. * deps: bump the axum group with 2 updates Pull-Request: libp2p#4943. * chore(webrtc-websys): remove unused dependencies Pull-Request: libp2p#4973. * chore(quic): fix link to PR in changelog Pull-Request: libp2p#4993. * deps: bump tokio from 1.34.0 to 1.35.0 Pull-Request: libp2p#4995. * deps: bump syn from 2.0.39 to 2.0.40 Pull-Request: libp2p#4996. * deps: bump once_cell from 1.18.0 to 1.19.0 Pull-Request: libp2p#4998. * deps: bump hkdf from 0.12.3 to 0.12.4 Pull-Request: libp2p#5009. * deps: bump clap from 4.4.10 to 4.4.11 Pull-Request: libp2p#4997. * deps: bump thiserror from 1.0.50 to 1.0.51 Pull-Request: libp2p#5010. * deps: bump syn from 2.0.40 to 2.0.41 Pull-Request: libp2p#5011. * deps: bump async-io from 2.2.1 to 2.2.2 Pull-Request: libp2p#5012. * deps: bump rust-embed from 8.0.0 to 8.1.0 Pull-Request: libp2p#5000. * chore(deps): bump golang.org/x/crypto from 0.7.0 to 0.17.0 Pull-Request: libp2p#5019. * deps: bump libc from 0.2.150 to 0.2.151 Pull-Request: libp2p#5002. * docs: remove security@libp2p.io I no longer have access to the mailing list. See libp2p#5007. Pull-Request: libp2p#5020. * chore: fix typos Pull-Request: libp2p#5021. * fix(derive): restore support for inline generic type constraints Fixes the `#[NetworkBehaviour]` macro to support generic constraints on behaviours without a where clause, which was the case before v0.51. Pull-Request: libp2p#5003. * deps: bump actions/deploy-pages from 3 to 4 Pull-Request: libp2p#5022. * chore: fix several typos in documentation Pull-Request: libp2p#5008. * deps: bump async-trait from 0.1.74 to 0.1.75 Pull-Request: libp2p#5029. * deps: bump anyhow from 1.0.75 to 1.0.76 Pull-Request: libp2p#5030. * deps: bump futures-util from 0.3.29 to 0.3.30 Pull-Request: libp2p#5031. * deps: bump syn from 2.0.41 to 2.0.43 Pull-Request: libp2p#5033. * deps: bump tokio from 1.35.0 to 1.35.1 Pull-Request: libp2p#5034. * deps: bump reqwest from 0.11.22 to 0.11.23 Pull-Request: libp2p#5035. * deps: bump futures from 0.3.29 to 0.3.30 Pull-Request: libp2p#5032. * deps: bump trybuild from 1.0.85 to 1.0.86 Pull-Request: libp2p#5036. * deps: bump proc-macro2 from 1.0.69 to 1.0.71 Pull-Request: libp2p#5041. * deps: bump actions/upload-pages-artifact from 2.0.0 to 3.0.0 Pull-Request: libp2p#5023. * deps: bump Rust to 1.75 and fix clippy lints Pull-Request: libp2p#5043. * deps: bump thiserror from 1.0.51 to 1.0.53 Pull-Request: libp2p#5044. * deps: bump clap from 4.4.11 to 4.4.12 Pull-Request: libp2p#5046. * deps: bump tempfile from 3.8.1 to 3.9.0 Pull-Request: libp2p#5047. * deps: bump rust-embed from 8.1.0 to 8.2.0 Pull-Request: libp2p#5049. * deps: bump serde_json from 1.0.108 to 1.0.109 Pull-Request: libp2p#5050. * deps: bump anyhow from 1.0.76 to 1.0.78 Pull-Request: libp2p#5051. * deps: bump proc-macro2 from 1.0.71 to 1.0.73 Pull-Request: libp2p#5054. * deps: bump quote from 1.0.33 to 1.0.34 Pull-Request: libp2p#5055. * deps: bump anyhow from 1.0.78 to 1.0.79 Pull-Request: libp2p#5062. * deps: bump serde_json from 1.0.109 to 1.0.111 Pull-Request: libp2p#5063. * deps: bump thiserror from 1.0.53 to 1.0.56 Pull-Request: libp2p#5064. * deps: bump libc from 0.2.151 to 0.2.152 Pull-Request: libp2p#5065. * deps: bump trybuild from 1.0.86 to 1.0.88 Pull-Request: libp2p#5068. * deps: bump proc-macro2 from 1.0.73 to 1.0.76 Pull-Request: libp2p#5069. * deps: bump clap from 4.4.12 to 4.4.13 Pull-Request: libp2p#5070. * deps: bump Swatinem/rust-cache from 2.7.1 to 2.7.2 Pull-Request: libp2p#5076. * deps: bump tj-actions/glob from 17 to 18 Pull-Request: libp2p#5058. * deps: bump the axum group with 1 update Pull-Request: libp2p#5045. * deps: bump quote from 1.0.34 to 1.0.35 Pull-Request: libp2p#5071. * deps: bump async-trait from 0.1.75 to 0.1.77 Pull-Request: libp2p#5081. * ci: add dependabot group for webrtc Pull-Request: libp2p#5082. * deps: bump base64 from 0.21.5 to 0.21.7 Pull-Request: libp2p#5086. * deps: bump trybuild from 1.0.88 to 1.0.89 Pull-Request: libp2p#5087. * deps: bump js-sys from 0.3.66 to 0.3.67 Pull-Request: libp2p#5091. * deps: bump wasm-bindgen from 0.2.89 to 0.2.90 Pull-Request: libp2p#5089. * add PeerId to ListenFailure --------- Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com> Co-authored-by: Doug A <douganderson444@gmail.com> Co-authored-by: Darius Clark <dariusc93@users.noreply.github.com> Co-authored-by: zhiqiangxu <652732310@qq.com> Co-authored-by: Thomas Eizinger <thomas@eizinger.io> Co-authored-by: maqi <qi.ma@maidsafe.net> Co-authored-by: stormshield-frb <144998884+stormshield-frb@users.noreply.github.com> Co-authored-by: Max Inden <mail@max-inden.de> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: NAHO <90870942+trueNAHO@users.noreply.github.com> Co-authored-by: alex <152680487+bodhi-crypo@users.noreply.github.com> Co-authored-by: Akosh Farkash <aakoshh@gmail.com> Co-authored-by: Frieren <153332328+Frierened@users.noreply.github.com>

Add `#[non_exhaustive]` to the following enums so that future additions don't cause breaking changes in downstream client code: `FromSwarm`, `ToSwarm`, `SwarmEvent`, `ConnectionHandlerEvent`, `ConnectionEvent`. Related: libp2p#4543. Pull-Request: libp2p#4581.

We can make `FromSwarm` implement `Copy` and `Close` which makes it much easier to a) generate code in `libp2p-swarm-derive` b) manually wrap a `NetworkBehaviour` Previously, we couldn't do this because `ConnectionClosed` would have a `handler` field that cannot be cloned / copied. Related: libp2p#4076. Related: libp2p#4581. Pull-Request: libp2p#4825.

adding #[non_exhaustive] to key enums

207c7ba

Signed-off-by: Dave Huseby <dwh@linuxprogrammer.org>

dhuseby self-assigned this Oct 2, 2023

dhuseby added 4 commits October 2, 2023 14:47

fix swarm/CHANGELOG.md

42a018f

Signed-off-by: Dave Huseby <dwh@linuxprogrammer.org>

Merge branch 'master' into add-non_exhaustive

cd26395

fix clippy CI error

9a844b2

Signed-off-by: Dave Huseby <dwh@linuxprogrammer.org>

Merge branch 'master' into add-non_exhaustive

c7d8084

thomaseizinger reviewed Oct 2, 2023

View reviewed changes

misc/allow-block-list/src/lib.rs Outdated Show resolved Hide resolved

swarm/CHANGELOG.md Outdated Show resolved Hide resolved

swarm/tests/swarm_derive.rs Outdated Show resolved Hide resolved

protocols/rendezvous/src/client.rs Outdated Show resolved Hide resolved

dhuseby and others added 3 commits October 2, 2023 18:21

Update swarm/CHANGELOG.md

8edbc27

Co-authored-by: Thomas Eizinger <thomas@eizinger.io>

Merge branch 'master' into add-non_exhaustive

f0ecf33

Merge branch 'add-non_exhaustive' of github:dhuseby/rust-libp2p into …

1e9561c

…add-non_exhaustive

dhuseby commented Oct 3, 2023

View reviewed changes

protocols/rendezvous/src/server.rs Show resolved Hide resolved

dhuseby added 2 commits October 2, 2023 20:19

more cleanup

2c8ec27

Signed-off-by: Dave Huseby <dwh@linuxprogrammer.org>

Merge branch 'master' into add-non_exhaustive

32fbbfa

thomaseizinger reviewed Oct 3, 2023

View reviewed changes

swarm-derive/src/lib.rs Outdated Show resolved Hide resolved

thomaseizinger reviewed Oct 3, 2023

View reviewed changes

swarm-derive/src/lib.rs Show resolved Hide resolved

Merge branch 'master' into add-non_exhaustive

607b6b5

mxinden reviewed Oct 16, 2023

View reviewed changes

misc/allow-block-list/src/lib.rs Outdated Show resolved Hide resolved

thomaseizinger added this to the v0.53.0 milestone Oct 20, 2023

thomaseizinger mentioned this pull request Oct 24, 2023

feat(swarm): allow behaviours to share addresses of peers #4371

Merged

4 tasks

dhuseby added 3 commits October 30, 2023 16:54

Merge branch 'master' into add-non_exhaustive

36c4ced

fixing merge errors

b87bf96

Signed-off-by: Dave Huseby <dwh@linuxprogrammer.org>

pinning libp2p-swarm-derive for safety

32ba7cd

Signed-off-by: Dave Huseby <dwh@linuxprogrammer.org>

thomaseizinger reviewed Oct 30, 2023

View reviewed changes

protocols/rendezvous/src/client.rs Outdated Show resolved Hide resolved

swarm-derive/src/lib.rs Outdated Show resolved Hide resolved

swarm-derive/Cargo.toml Outdated Show resolved Hide resolved

swarm/Cargo.toml Outdated Show resolved Hide resolved

integrating review changes

b8fd915

Signed-off-by: Dave Huseby <dwh@linuxprogrammer.org>

mxinden reviewed Oct 31, 2023

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

dhuseby and others added 2 commits October 31, 2023 11:52

Merge branch 'master' into add-non_exhaustive

1797e27

Update Cargo.toml

733e617

add a warning to future developers about bumping the version. Co-authored-by: Max Inden <mail@max-inden.de>

thomaseizinger added the internal-change Pull requests that make internal changes to crates and thus don't need to include a changelog entry. label Nov 1, 2023

thomaseizinger reviewed Nov 1, 2023

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

thomaseizinger added 3 commits November 2, 2023 17:16

Revert "updating CHANGELOGs"

3277209

This reverts commit 344e012.

Revert "add libp2p-swarm-derive version pin test"

c85bb0b

This reverts commit e6aff9f.

Extend check to cover pinned version

3c3e7b5

dhuseby added 4 commits November 2, 2023 09:31

Merge branch 'master' into add-non_exhaustive

cdd21aa

update CHANGELOG for swarm-derive

f796df0

Signed-off-by: Dave Huseby <dwh@linuxprogrammer.org>

Merge branch 'add-non_exhaustive' of github:dhuseby/rust-libp2p into …

f0c4e0a

…add-non_exhaustive

revert swarm-derive/CHANGELOG update

e37cbc4

Signed-off-by: Dave Huseby <dwh@linuxprogrammer.org>

mxinden approved these changes Nov 2, 2023

View reviewed changes

mxinden added the send-it label Nov 2, 2023

Merge branch 'master' into add-non_exhaustive

81d7835

mergify bot merged commit a428ffd into libp2p:master Nov 2, 2023
71 checks passed

thomaseizinger mentioned this pull request Nov 2, 2023

v0.53 release #4545

Closed

thomaseizinger mentioned this pull request Nov 9, 2023

feat(swarm): implement Copy and Clone for FromSwarm #4825

Merged

4 tasks

dhuseby deleted the add-non_exhaustive branch March 6, 2024 02:49

nazar-pc mentioned this pull request Oct 27, 2024

Upgrade libp2p from 0.52.4 to 0.54.1 paritytech/polkadot-sdk#6248

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(swarm): add `#[non_exhaustive]` to key enums #4581

feat(swarm): add `#[non_exhaustive]` to key enums #4581

dhuseby commented Oct 2, 2023 •

edited

Loading

thomaseizinger left a comment

mergify bot commented Oct 20, 2023

thomaseizinger left a comment

mxinden left a comment

mergify bot commented Oct 31, 2023

dhuseby commented Oct 31, 2023

thomaseizinger commented Nov 2, 2023

mxinden left a comment

dhuseby commented Nov 2, 2023

nazar-pc commented Nov 8, 2023

thomaseizinger commented Nov 9, 2023 •

edited

Loading

thomaseizinger commented Nov 9, 2023

nazar-pc commented Nov 9, 2023

thomaseizinger commented Nov 9, 2023

thomaseizinger commented Nov 9, 2023

feat(swarm): add #[non_exhaustive] to key enums #4581

feat(swarm): add #[non_exhaustive] to key enums #4581

Conversation

dhuseby commented Oct 2, 2023 • edited Loading

Description

Notes & open questions

Change checklist

thomaseizinger left a comment

Choose a reason for hiding this comment

mergify bot commented Oct 20, 2023

thomaseizinger left a comment

Choose a reason for hiding this comment

mxinden left a comment

Choose a reason for hiding this comment

mergify bot commented Oct 31, 2023

dhuseby commented Oct 31, 2023

thomaseizinger commented Nov 2, 2023

mxinden left a comment

Choose a reason for hiding this comment

dhuseby commented Nov 2, 2023

nazar-pc commented Nov 8, 2023

thomaseizinger commented Nov 9, 2023 • edited Loading

thomaseizinger commented Nov 9, 2023

nazar-pc commented Nov 9, 2023

thomaseizinger commented Nov 9, 2023

thomaseizinger commented Nov 9, 2023

feat(swarm): add `#[non_exhaustive]` to key enums #4581

feat(swarm): add `#[non_exhaustive]` to key enums #4581

dhuseby commented Oct 2, 2023 •

edited

Loading

thomaseizinger commented Nov 9, 2023 •

edited

Loading