refactor: make debug-print of StreamProtocol
more concise
#4631
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
fmt::Debug
implementation of a type should in most cases reveal its internal structure.StreamProtocol
is likely to be debug-printed a lot and in many cases, the only contract is thefmt::Debug
impl. The internals ofStreamProtocol
only exist for performance reasons to avoid allocations for statically-known protocol strings. Revealing this implementation detail isn't particularly beneficial to end users. At the same time, the current implementation is very noise.Previously, the
protocols
field of anidentify::Info
would e.g. read as:With this patch, it reads as:
Notes & open questions
Change checklist