fix(browser-webrtc-example): use tracing-wasm logger
#4952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
log was replaced by tracing, so we use tracing-wasm here instead of the legacy wasm-logger to get our output logs
DougAnderson444
changed the title
wasm-logger with tracing-wasmthere's no need to include the wasm feature on the tokio config
DougAnderson444
force-pushed
the
fix-example-webrtc
branch
from
e868fc9
to
978d30a
Compare
thomaseizinger
changed the title
tracing-wasm logger
thomaseizinger
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
logwas replaced bytracing, it broke the logging in this example. Now we can usetracing-wasminstead of the legacywasm-loggerto get our output logs.Description
Upgrade
wasm-loggertotracing-wasm.Related: #4950.
Notes & open questions
None, just figure logs will be useful to troubleshoot #4950.
Change checklist
[x] I have made corresponding changes to the documentation[x] I have added tests that prove my fix is effective or that my feature works[x] A changelog entry has been made in the appropriate crates