Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps(quic): update quinn to 0.11 and libp2p-tls to 0.4.0 #5316

Merged
merged 29 commits into from
May 23, 2024
Merged

deps(quic): update quinn to 0.11 and libp2p-tls to 0.4.0 #5316

merged 29 commits into from
May 23, 2024

Conversation

retrohacker
Copy link
Contributor

@retrohacker retrohacker commented Apr 17, 2024 •
edited by jxs
Loading

Description

This PR updates the following dependencies quic:

  • quinn@0.10.2 -> quinn@0.11.0
  • rustls@0.21.9 -> rustls@0.23.4

Notes & open questions

The new rustls types now use borrowed references by default and require you to take ownership of them by cloning explicitly (gated behind the alloc feature).

I'm not very good with rust lifetimes and I don't think I'm approaching them correctly in this PR. The <'static> seems wrong for example.

While working on this PR, I noticed the max_bytes, max_percentages tests are flakey on my machine. They both fail for me intermittently on the master branch.

I have them commented out right now for local dev but they need to be added back in before merge.

I also believe this is a breaking change since we seem to expose rustls.

quinn has not yet released support for rustls@0.23 or ring@0.17, I'm referencing it as a git dependency until their PR is merged.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 17, 2024

This pull request has merge conflicts. Could you please resolve them @retrohacker? 🙏

@retrohacker
Copy link
Contributor Author

quinn PR merged, waiting on .11 release: quinn-rs/quinn#1737

@ljedrz
Copy link

ljedrz commented May 9, 2024

FYI, quinn has already been updated.

jxs
jxs reviewed May 10, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this started! Left some comments

identity/Cargo.toml Outdated Show resolved Hide resolved
transports/quic/src/config.rs Outdated Show resolved Hide resolved
transports/quic/Cargo.toml Outdated Show resolved Hide resolved
misc/memory-connection-limits/tests/max_bytes.rs Outdated Show resolved Hide resolved
transports/quic/src/config.rs Outdated Show resolved Hide resolved
transports/quic/src/transport.rs Outdated Show resolved Hide resolved
transports/websocket/src/tls.rs Outdated Show resolved Hide resolved
@mergify Mergify
Copy link
Contributor

mergify bot commented May 13, 2024

This pull request has merge conflicts. Could you please resolve them @retrohacker? 🙏

@jxs
Copy link
Member

jxs commented May 13, 2024 •
edited
Loading

meanwhile, I split the updates into different PR's to separate dependencies per crate, like #5384 let's also make this one constrain to quic only and we'll do tls in a subsequent one

@mergify Mergify
Copy link
Contributor

mergify bot commented May 14, 2024

This pull request has merge conflicts. Could you please resolve them @retrohacker? 🙏

@jxs jxs mentioned this pull request May 14, 2024
Merged
@jxs jxs changed the base branch from master to update-rustls-tls May 14, 2024 15:33
@mergify Mergify
Copy link
Contributor

mergify bot commented May 14, 2024

This pull request has merge conflicts. Could you please resolve them @retrohacker? 🙏

@jxs jxs force-pushed the retrohacker/ring@0.17.8 branch from 5c3e4fe to 10600bb Compare May 14, 2024 15:46
@jxs jxs changed the title Retrohacker/ring@0.17.8 deps(quic): update quinn to 0.11 and libp2p-tls to 0.4.0 May 14, 2024
@jxs jxs force-pushed the retrohacker/ring@0.17.8 branch from ba00cfb to d33c3a6 Compare May 14, 2024 21:50
@jxs jxs force-pushed the retrohacker/ring@0.17.8 branch from 8d2dc3e to b281a69 Compare May 14, 2024 22:41
@mergify Mergify
Copy link
Contributor

mergify bot commented May 14, 2024

This pull request has merge conflicts. Could you please resolve them @retrohacker? 🙏

@jxs jxs force-pushed the retrohacker/ring@0.17.8 branch from b281a69 to 8d2dc3e Compare May 14, 2024 22:44
dependabot bot and others added 5 commits May 14, 2024 23:45
@dependabot @jxs
chore(deps): bump golang.org/x/net from 0.21.0 to 0.23.0
7bd89c4 
Pull-Request: libp2p#5325.
@Wiezzel @jxs
feat(quic): allow setting the MTU discovery upper bound
c120e12 
The default MTU discovery upper bound is too high for some environments and results in permanent warnings. As I'd like to be able to configure this setting, adding a new method for the `Config`.

Pull-Request: libp2p#5386.
@jxs
update CHANGELOG.md
7632e1d
@jxs
update versions
df89e25
@jxs
increase write_after_peer_dropped_stream delay
09e4983
@jxs jxs force-pushed the retrohacker/ring@0.17.8 branch from 8d2dc3e to 09e4983 Compare May 14, 2024 22:46
@mergify Mergify
Copy link
Contributor

mergify bot commented May 14, 2024

This pull request has merge conflicts. Could you please resolve them @retrohacker? 🙏

@jxs jxs requested a review from thomaseizinger May 14, 2024 23:43
@jxs jxs force-pushed the retrohacker/ring@0.17.8 branch from 9759473 to 073110e Compare May 14, 2024 23:47
@jxs jxs changed the base branch from update-rustls-tls to master May 18, 2024 00:42
@mergify Mergify
Copy link
Contributor

mergify bot commented May 18, 2024

This pull request has merge conflicts. Could you please resolve them @retrohacker? 🙏

@mergify Mergify
Copy link
Contributor

mergify bot commented May 19, 2024

This pull request has merge conflicts. Could you please resolve them @retrohacker? 🙏

@jxs jxs force-pushed the retrohacker/ring@0.17.8 branch from 88d4af5 to b1ee056 Compare May 23, 2024 14:52
@jxs jxs added the send-it label May 23, 2024
@mergify mergify bot merged commit 94fef37 into libp2p:master May 23, 2024
72 checks passed
@jxs
Copy link
Member

jxs commented May 23, 2024

released libp2p-quic 0.10.3 cc @Wiezzel for the MTU discovery upper bound.

TimTinkers pushed a commit to unattended-backpack/rust-libp2p that referenced this pull request Sep 14, 2024
@retrohacker @TimTinkers
deps(quic): update quinn to 0.11 and libp2p-tls to 0.4.0
b8953e0 
This PR updates the following dependencies `quic`:

* `quinn@0.10.2` -> `quinn@0.11.0`
* `rustls@0.21.9` -> `rustls@0.23.4`

Pull-Request: libp2p#5316.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs left review comments

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@retrohacker @ljedrz @jxs @thomaseizinger @Wiezzel