-
Notifications
You must be signed in to change notification settings - Fork 962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gossipsub): add instant to make gossipsub work on browser #5637
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, and thanks for this! I'd rather we try to fix this upstream, let's do this if you agree, we submit a fix upstream and give it a window to be merged and released, if it doesn't we address the issue via this PR.
cc @dariusc93
Thanks for the PR @shuning-auki!
I agree. It is a simple fix upstream while the PR (per suggestion from the issue) is more of a temporary workaround to get this back working unless we wish to remove |
This pull request has merge conflicts. Could you please resolve them @shuning-auki? 🙏 |
As I think on this, I wonder if we could remove Thoughts on this @jxs @shuning-auki? It would be one less dependency |
yeah makes sense to me, thanks for investigating Darius. If anyone wants to ahead and do it, otherwise I can also take a stab at it :) |
Description
Related #5620
Notes & open questions
Change checklist