Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gossipsub): add instant to make gossipsub work on browser #5637

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shuning-auki
Copy link

Description

Related #5620

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@shuning-auki shuning-auki changed the title add instant to make gossipsub work on browser fix: add instant to make gossipsub work on browser Oct 15, 2024
@shuning-auki shuning-auki changed the title fix: add instant to make gossipsub work on browser fix(gossipsub): add instant to make gossipsub work on browser Oct 15, 2024
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, and thanks for this! I'd rather we try to fix this upstream, let's do this if you agree, we submit a fix upstream and give it a window to be merged and released, if it doesn't we address the issue via this PR.
cc @dariusc93

@dariusc93
Copy link
Member

Thanks for the PR @shuning-auki!

Hi, and thanks for this! I'd rather we try to fix this upstream, let's do this if you agree, we submit a fix upstream and give it a window to be merged and released, if it doesn't we address the issue via this PR. cc @dariusc93

I agree. It is a simple fix upstream while the PR (per suggestion from the issue) is more of a temporary workaround to get this back working unless we wish to remove futures-ticker altogether if a fix isnt merged upstream.

Copy link
Contributor

mergify bot commented Oct 25, 2024

This pull request has merge conflicts. Could you please resolve them @shuning-auki? 🙏

@dariusc93
Copy link
Member

As I think on this, I wonder if we could remove futures-ticker instead. It was introduced in #3973 and from my understanding it was to used as an Interval alternative to wasm-timer Interval. Should be a simple change by using Delay from futures-timer instead (though would still need a little rework of logic)

Thoughts on this @jxs @shuning-auki? It would be one less dependency

@jxs
Copy link
Member

jxs commented Nov 11, 2024

As I think on this, I wonder if we could remove futures-ticker instead. It was introduced in #3973 and from my understanding it was to used as an Interval alternative to wasm-timer Interval. Should be a simple change by using Delay from futures-timer instead (though would still need a little rework of logic)

Thoughts on this @jxs @shuning-auki? It would be one less dependency

yeah makes sense to me, thanks for investigating Darius. If anyone wants to ahead and do it, otherwise I can also take a stab at it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants