autonat/README: Document DOS attack prevention #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document that peers MUST NOT dial addresses that are not based on the IP addresses the requesting node is observed as. Corresponding logic in Golang implementation: https://github.com/libp2p/go-libp2p-autonat/blob/1247ac6d9fa798e7032127878a6f3d0b9eb487c6/svc.go#L133-L147
autonat/README.md
Outdated
| @@ -52,6 +52,23 @@ Upon receiving this message, the peer starts to dial these addresses. It MAY | |||
| dial all of them in parallel. The peer MAY use a different IP and peer ID than | |||
| it uses for its regular libp2p connection to perform these dial backs. | |||
|
|
|||
| In order to prevent attacks like the one described below, implementations | |||
| MUST NOT dial any multiaddress unless it is based on the IP address the | |||
| requesting node is observed as. | |||
There was a problem hiding this comment.
Suggested change
| requesting node is observed as. | |
| requesting node is observed as, as described in [RFC 3489, Section 12.1.1](https://www.rfc-editor.org/rfc/rfc3489#section-12.1.1): |
There was a problem hiding this comment.
I am a bit confused. Is the full citation of the paragraph + the link below not enough?
There was a problem hiding this comment.
Sorry for the confusion. I'd prefer to have the link above, not below. If you accept this suggestion, please remove the link below.
There was a problem hiding this comment.
Addressed in 314ae0e with a slight rewording. Let me know what you think @marten-seemann.
mxinden
force-pushed
the
autonat-ddos-attack
branch
from
d806703
to
314ae0e
Compare
|
Sorry for the force-push. I missed that the |
marten-seemann
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document that peers MUST NOT dial addresses that are not based on the IP
addresses the requesting node is observed as.
Corresponding logic in Golang implementation:
https://github.com/libp2p/go-libp2p-autonat/blob/1247ac6d9fa798e7032127878a6f3d0b9eb487c6/svc.go#L133-L147
(Pointed out by @marten-seemann.)