connection/README: Recommend yamux over mplex #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mplex multiplexer does not provide backpressure on a stream. Yamux does. Given that this is a fundamental feature of a stream multiplexer, this commit changes the spec to recommend yamux over mplex. While yamux is not ideal, e.g. lacks backpressure on the connection level and the number of streams, it is superior in all cases to mplex.
Stebalien
approved these changes
Mar 16, 2022
|
@marten-seemann looks good to you? |
marten-seemann
approved these changes
Mar 17, 2022
2 tasks
15 tasks
This was referenced May 31, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mplex multiplexer does not provide backpressure on a stream. Yamux does.
Given that this is a fundamental feature of a stream multiplexer, this commit
changes the spec to recommend yamux over mplex.
While yamux is not ideal, e.g. lacks backpressure on the connection level and
the number of streams, it is superior in all cases to mplex.
I don't think we should recommend mplex over yamux any longer. Thoughts?