Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproducable JS yamux <> Rust yamux test failure #178

Closed
wants to merge 1 commit into from

Conversation

thomaseizinger
Copy link
Contributor

@thomaseizinger thomaseizinger commented May 4, 2023

This is a test branch for the error that I am seeing in libp2p/rust-libp2p#3013.

cc @MarcoPolo @achingbrain

The results are:

name,outcome
"js-head x rust-bump-yamux (tcp, noise, yamux)",failure
"js-head x js-head (tcp, noise, yamux)",success
"rust-bump-yamux x rust-bump-yamux (tcp, noise, yamux)",success
"rust-bump-yamux x js-head (tcp, noise, yamux)",success

It only fails in one direction!

},
"dependencies": {
"@chainsafe/libp2p-noise": "^10.2.0",
"@chainsafe/libp2p-yamux": "^4.0.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've bumped to the latest libp2p-yamux here.

@p-shahi
Copy link
Member

p-shahi commented May 30, 2023

Can we close this @thomaseizinger ?

@p-shahi p-shahi closed this May 30, 2023
@thomaseizinger
Copy link
Contributor Author

Can we close this @thomaseizinger ?

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants