fix(perf): increase root volume size #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple perf runs have failed due to "no space left on device". See e.g. https://github.com/libp2p/test-plans/actions/runs/5727165977/job/15527780097. The perf terraform launch template previously did not specify a root volume size. Thus terraform used the default: ``` df -h Filesystem Size Used Avail Use% Mounted on devtmpfs 4.0M 0 4.0M 0% /dev tmpfs 63G 0 63G 0% /dev/shm tmpfs 25G 540K 25G 1% /run /dev/nvme0n1p1 8.0G 1.9G 6.1G 24% / tmpfs 63G 0 63G 0% /tmp tmpfs 13G 0 13G 0% /run/user/1000 ``` With this commit the root volume is increased to 100GB: ``` df -h Filesystem Size Used Avail Use% Mounted on devtmpfs 4.0M 0 4.0M 0% /dev tmpfs 63G 0 63G 0% /dev/shm tmpfs 25G 564K 25G 1% /run /dev/nvme0n1p1 100G 2.6G 98G 3% / tmpfs 63G 8.0K 63G 1% /tmp tmpfs 13G 0 13G 0% /run/user/0 tmpfs 13G 0 13G 0% /run/user/1000 ```
|
Corresponding perf run https://github.com/libp2p/test-plans/actions/runs/5760549607/job/15616708357 |
|
Moving forward here. Happy to address reviews afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple perf runs have failed due to "no space left on device". See e.g. https://github.com/libp2p/test-plans/actions/runs/5727165977/job/15527780097.
The perf terraform launch template previously did not specify a root volume size. Thus terraform used the default:
With this commit the root volume is increased to 100GB:
//CC @galargh in case you have some time to take a quick look.
//CC @thomaseizinger given that we faced this issue on #247.
//CC @maschad since you have seen this issue on your personal AWS account.