Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add perf to readme #271

Merged
merged 3 commits into from
Aug 25, 2023
Merged

chore: add perf to readme #271

merged 3 commits into from
Aug 25, 2023

Conversation

p-shahi
Copy link
Member

@p-shahi p-shahi commented Aug 22, 2023

No description provided.

@p-shahi p-shahi requested a review from mxinden August 22, 2023 23:39
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @p-shahi. I am in favor of Thomas suggestions.

README.md Outdated
@@ -16,6 +19,10 @@ More specs to come soon!

These test-plans historically used Testground. To read why we're now using `docker compose` instead please see: [Why we're moving away from Testground](https://github.com/libp2p/test-plans/issues/103)

## Performance Benchmarking

Please see the [libp2p perf protocol](https://github.com/libp2p/specs/blob/master/perf/perf.md) and the [benchmarking README](https://github.com/libp2p/test-plans/tree/master/perf#libp2p-performance-benchmarking).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the perf/README.md already points to the libp2p perf protocol specification. Slight preference for not linking to the specs repository twice.

Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
README.md Outdated Show resolved Hide resolved
@p-shahi p-shahi merged commit 20b73dd into master Aug 25, 2023
@p-shahi p-shahi deleted the updatereadme branch August 25, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants