chore: add js-libp2p@v1.3.0 to transport-interop #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
SgtPooki
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
looks good to me but I would ensure @achingbrain has a look
achingbrain
reviewed
Apr 10, 2024
| @@ -0,0 +1,11 @@ | |||
| # Here because we want to fetch the node_modules within docker so that it's | |||
| # installed on the same platform the test is run. Otherwise tools like `esbuild` will fail to run | |||
| FROM node:18.17.1 | |||
There was a problem hiding this comment.
We should use LTS here:
Suggested change
| FROM node:18.17.1 | |
| FROM node:20.12.1 |
|
I'm pretty sure I've fixed this by patching the js-libp2p tests to use the ipv4 loopback address instead of "localhost". See #365 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds js-libp2p@v1.3.0 to transport-interop
Closes #364