Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emulator corr indexing #657

Open
wants to merge 6 commits into
base: v0.58.0-release
Choose a base branch
from

Conversation

dmcdougall
Copy link
Member

@roystgnr this is what I've been working on. Super not ready to merge yet.

We were assuming only one basis vector when indexing the emulator
correlation strength.
This relied on the correct calculation of how many emulator correlation
strength parameters there were; we had assumed there was one svd term.
Again, this relied on the calculation of the number of emulator
correlation strength parameters.  We had assumed there was one svd basis
vector which is an incorrect assumption.
There are num_svd_terms of these things, not 1.
We were underestimating how many of these variables there were.  There
aren't always dimScenario+dimParameter.  There's
dimScenario+dimParameter *for each* emulator precision variable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant