Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

segfault when connecting to blank host server #4703

Closed
ghost opened this issue Feb 27, 2017 · 2 comments
Closed

segfault when connecting to blank host server #4703

ghost opened this issue Feb 27, 2017 · 2 comments

Comments

@ghost
Copy link

ghost commented Feb 27, 2017 •
edited by ghost
Loading

First and foremost consider this:

  • Only RetroArch bugs should be filed here. Not core bugs or game bugs
  • This is not a forum or a help section, this is strictly developer oriented

Description

Entering nothing(or just blank) in connect to netplay hose causes segfault.

Expected behavior

should just return to netplay menu when server(or host address) is invalid or not available or similar.

Actual behavior

segfault

Steps to reproduce the bug

  1. run RA, launch game
  2. goto quick menu, goto Netplay
  3. choose connect to netplay host
  4. enter nothing, or leave it blank
  5. press Enter on keyboard or button 1 in gamepad(whichever is set to OK)
    6.segfault

Bisect Results

bt https://hastebin.com/jivaxegevi.go

Version/Commit

You can find this information under Information/System Information

Environment information

  • OS: Windows 10-x64 / Ubuntu 16.10
  • Compiler: gcc 6.3.0 / gcc 6.2.0
ghost pushed a commit that referenced this issue Mar 14, 2017
missing null pointer check, just close dialog if no hostname was spec…
32a5c1a 
…ified, fixes issue #4703
@ghost
Copy link

ghost commented Mar 14, 2017

Should be fixed in 32a5c1a, can you confirm?

@ghost
Copy link
Author

ghost commented Mar 14, 2017

this should be OK now.

@ghost ghost closed this as completed Mar 14, 2017
0-wiz-0 pushed a commit to NetBSD/pkgsrc-wip that referenced this issue Jun 1, 2017
@alarixnia
retroarch: Update to 1.6.0
cf69666 
– AUTOSAVE/SRAM – Fix bug #3829 / #4820 (libretro/RetroArch#3829)
– ENDIANNESS: Fixed database scanning. Should fix scanning on PS3/WiiU/Wii, etc.
– NET: Fix bug #4703 (libretro/RetroArch#4703)
– ANDROID: Runtime permission checking
– ANDROID: Improve autoconf fallback
– ANDROID: Improve shield portable/gamepad device grouping workaround
– ANDROID: Allow remotes to retain OK/Cancel position when menu_swap_ok_cancel is enabled
– LOCALIZATION: Update/finish French translation
– LOCALIZATION: Update German translation
– LOCALIZATION: Update Japanese translation
– LOCALIZATION/GUI: Korean font should display properly now with XMB/MaterialUI’s default font
– MENU: Improved rendering for XMB ribbon; using additive blending (Vulkan/GL)
– OSX/MACOS: Fixes serious memory leak
– WINDOWS: Added WASAPI audio driver for low-latency audio. Both shared and exclusive mode.
– WINDOWS: Added RawInput input driver for low-latency, low-level input.
– WINDOWS: Core mouse input should be relative again in cores
– MISC: Various frontend optimizations.
– VIDEO: Fix threaded video regression; tickering of menu entries would no longer work.
– WII: Fix crashing issues which could occur with the dummy core
– WIIU: HID Controller support
– WIIU: XMB/MaterialUI menu driver support
– WIIU: Initial network/netplay support
– LOBBIES: Fallback to filename based matching if no CRC matches are found (for people making playlists by hand)
– LOBBIES: GUI refinement, show stop hosting when a host has been started, show disconnect when playing as client
– LOBBIES: if the game is already loaded it will try to connect directly instead of re-loading content (non-fullpath cores only)
– LOBBIES: unify both netplay menus
– THUMBNAILS: Thumbnails show up now in Load Content -> Collection, Information -> Database
– VITA: Fix slow I/O
– VITA: Fix 30fps menu (poke into input now instead of reading the entire input buffer which apparently is slow)
– VITA: Fix frame throttle
– VULKAN: Unicode font rendering support. Should fix bad character encoding for French characters, etc.
– VULKAN: Fix some crashes on loading some thumbnails
– AUDIO: Audio mixer support. Mix up to 8 streams with the game’s audio.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants