Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only add mouse if it has buttons and add vebose device friendly names #12536

Merged
merged 5 commits into from Jun 22, 2021
Merged

only add mouse if it has buttons and add vebose device friendly names #12536

merged 5 commits into from Jun 22, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 18, 2021

Udev is adding two devices per mice this fixes that issue there is also no udev logging when a device is added that was removed at some point. Ive also added the device friendly name to the logging. Note I do have two mice and keyboards plugged in for testing.

[INFO] [udev]: Added Device Keyboard Telink Wireless Receiver (/dev/input/event7).
[INFO] [udev]: Added Device Keyboard AT Translated Set 2 keyboard (/dev/input/event3).
[INFO] [udev]: Added Device Mouse Telink Wireless Receiver Mouse (/dev/input/event4).
[INFO] [udev]: Added Device Mouse ETPS/2 Elantech Touchpad (/dev/input/event10).

also fixed game focus mode in udev not working. I looked at dinput driver for windows seems like it will need updated as well is using the same logic that didnt work on this driver.

@ghost ghost changed the title only add mouse if it ha buttons and add vebose device friendly names only add mouse if it has buttons and add vebose device friendly names Jun 18, 2021
@markwkidd
Copy link
Contributor

Nice!

@inactive123
Copy link
Contributor

Hi, thanks for the contribution. I will ask some teammembers to review this shortly.

@ghost
Copy link
Author

ghost commented Jun 20, 2021

no problems the dev/mouse[x] is a legacy hack for old programs to access usb mice as ps2 mice. We have no need for it .

https://www.kernel.org/doc/html/latest/input/input.html section 1.3.1.3 even a touch screen has a button and pointer device will have at least one button.

@inactive123
Copy link
Contributor

@jdgleaver reviewed this and said it's probably fine to merge as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants