-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
android: enable sustained performance mode if supported #6894
Conversation
If anyone needs an apk to test, I put one up here: http://buildbot.libretro.com/.bp/retroarch-release.apk It does not include any assets or additional files, just the binary itself. |
I would make it an option and off by default, so people with overheating issues can turn it on. |
@xTMODx I'm still a bit confused as to the actual intent of this feature. In the original issue report, it said that it "would prevent throttling", which I assume would be the opposite effect of what happens in an overheating situation (e.g. throttling clocks down, not up). I assumed that "sustained performance" meant "always good performance", but I may be mistaken there... and the API docs only say that it provides a "predictable, consistent level of device performance". Do you know of any better documentation on this? |
From what I read sustainable performance mode is overall slower. For a
device like the Shield ATV with active cooling it could do more harm than
not, but for people for handsets it maybe good.
I think it should be optional, on by default? I guess
hrydgard/ppsspp#9901
https://source.android.com/devices/tech/power/performance
…On Mon, Jun 18, 2018 at 6:22 PM, bparker06 ***@***.***> wrote:
@xTMODx <https://github.com/xTMODx> I'm still a bit confused as to the
actual intent of this feature. In the original issue report, it said that
it "would prevent throttling", which I assume would be the opposite effect
of what happens in an overheating situation (e.g. throttling clocks down,
not up). I assumed that "sustained performance" meant "always good
performance", but I may be mistaken there... and the API docs only say that
it provides a "predictable, consistent level of device performance".
Do you know of any better documentation on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6894 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABpC0NssrQeHN67d0ptRbBdqx4SUwlheks5t-DYlgaJpZM4UsIoq>
.
|
No sorry i dont know anything about it. |
OK, I discussed with @bparker06 what we should do. We agreed on the following: 1 - I will merge this right now in its current state. If everybody can live with this, I'd like to act on this and merge this so we can get this done. |
added the option in #6898 |
Fixes #5316.
I'm assuming this is something we do want to have enabled all the time? I know PPSSPP makes it an option, but do we really need that? If so I can add it (and let me know the default setting).
Also do note that this bumps the target API from 23 to 24. Would appreciate testing from @fr500 and/or @meepingsnesroms if needed. Unfortunately I'm not sure how to actually test this feature.