Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: enable sustained performance mode if supported #6894

Merged
merged 1 commit into from
Jun 19, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jun 18, 2018

Fixes #5316.

I'm assuming this is something we do want to have enabled all the time? I know PPSSPP makes it an option, but do we really need that? If so I can add it (and let me know the default setting).

Also do note that this bumps the target API from 23 to 24. Would appreciate testing from @fr500 and/or @meepingsnesroms if needed. Unfortunately I'm not sure how to actually test this feature.

@ghost
Copy link
Author

ghost commented Jun 18, 2018

If anyone needs an apk to test, I put one up here: http://buildbot.libretro.com/.bp/retroarch-release.apk

It does not include any assets or additional files, just the binary itself.

@xTMODx
Copy link

xTMODx commented Jun 18, 2018

I would make it an option and off by default, so people with overheating issues can turn it on.

@ghost
Copy link
Author

ghost commented Jun 18, 2018

@xTMODx I'm still a bit confused as to the actual intent of this feature. In the original issue report, it said that it "would prevent throttling", which I assume would be the opposite effect of what happens in an overheating situation (e.g. throttling clocks down, not up). I assumed that "sustained performance" meant "always good performance", but I may be mistaken there... and the API docs only say that it provides a "predictable, consistent level of device performance".

Do you know of any better documentation on this?

@andres-asm
Copy link
Contributor

andres-asm commented Jun 19, 2018 via email

@xTMODx
Copy link

xTMODx commented Jun 19, 2018

No sorry i dont know anything about it.
I just played 30min BSNES Mercury Balanced core and the framerates dropped after 20min playing, maybe the cpu was throttled i dont know

@inactive123
Copy link
Contributor

OK, I discussed with @bparker06 what we should do. We agreed on the following:

1 - I will merge this right now in its current state.
2 - I will add a 'Power Management' submenu to Settings.
3 - After this is done, @bparker06 will make a new PR adding a setting for enabling/disabling Sustained performance mode.

If everybody can live with this, I'd like to act on this and merge this so we can get this done.

@inactive123 inactive123 merged commit 48128a9 into master Jun 19, 2018
@ghost ghost deleted the android_susperf branch June 19, 2018 13:54
@ghost
Copy link
Author

ghost commented Jun 19, 2018

added the option in #6898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants