Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create android/Sony_DualSense_v2 #948

Closed
wants to merge 3 commits into from
Closed

Create android/Sony_DualSense_v2 #948

wants to merge 3 commits into from

Conversation

davidhedlund
Copy link
Contributor

@davidhedlund davidhedlund commented Nov 22, 2023

Generated from

  • OS: Google TV 12 (it's based on Android 12, see below). Kernel version: 5.4 (Google TV: Settings -> System -> About -> Kernel version)
  • RA installed via: Google Play
  • Retroarch version: 1.9.12

RetroArch:

  • Main Menu -> Information -> System Information -> Frontend Identifier: android [default]
  • Main Menu -> Information -> System Information -> Frontend Name: Chromecast HD
  • Main Menu -> Information -> System Information -> Frontend OS: Android (v12.0)
  • Settings -> Drivers -> Controller -> Controller: android [default]

android/Dual Sense 5.cfg didn't work in Google TV 10. For more info see:

android/Dual Sense 5.cfg didn't work in Google TV 10 (based on Android 12) so I made this file.

For more info see:
* #940
@davidhedlund davidhedlund changed the title Create Dual Sense 5 - generated with Google TV 10.cfg Create android/Dual Sense 5 - generated with Google TV 10.cfg Nov 22, 2023
@davidhedlund davidhedlund changed the title Create android/Dual Sense 5 - generated with Google TV 10.cfg Create android/Dual Sense 5 for Android 12 Nov 23, 2023
input_vendor_id = "1356"
input_product_id = "3302"
@davidhedlund davidhedlund changed the title Create android/Dual Sense 5 for Android 12 Create android/Sony_DualSense_v2 Nov 24, 2023
@RobLoach RobLoach marked this pull request as ready for review November 26, 2023 19:04
@RobLoach
Copy link
Member

Looks like there's another Duel Sense? Think your changes could override the original?

Some duplicate profiles were found
Duplicates inside 'android'
Vendor ID: 1356 - Product ID: 3302 - Name: Wireless Controller
- android/Dual Sense 5 - generated with Google TV 10.cfg
- android/Dual Sense 5.cfg

@davidhedlund
Copy link
Contributor Author

davidhedlund commented Nov 30, 2023

Looks like there's another Duel Sense?

Hi again Rob! It's DualSense (just made pull request by the way), and I evaluated an original gamepad from Sony.

Think your changes could override the original?

Some duplicate profiles were found
Duplicates inside 'android'
Vendor ID: 1356 - Product ID: 3302 - Name: Wireless Controller
- android/Dual Sense 5 - generated with Google TV 10.cfg
- android/Dual Sense 5.cfg

The original config works for Android Common Kernels (ACK) 4.14, but not for 5.4,and vice versa. See the table for more info:

With that said, ideally we should include the supported ACK version in the filename, but since I don't have a reference to the kernel version support I simply suggested "Sony_DualSense_v2"

@RobLoach
Copy link
Member

RobLoach commented Dec 3, 2023

We will have to make sure there aren't any duplicate configs, or keep the V2 IDs commented out. I'd suggest targeting the new firmware one here, tbh. As a general rule of thumb, could be good to recommend people update their gamepad firmware.

@davidhedlund
Copy link
Contributor Author

davidhedlund commented Dec 3, 2023

We will have to make sure there aren't any duplicate configs, or keep the V2 IDs commented out. I'd suggest targeting the new firmware one here, tbh. As a general rule of thumb, could be good to recommend people update their gamepad firmware.

I'm using the latest DualSense firmware.

The Android kernel (based on the Linux kernel) decides how DualSense should be handled. I don't know if the firmware affects the key bindings. Should we include the DualSense firmware or android kernel version in the cfg file name?

@davidhedlund davidhedlund closed this by deleting the head repository Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants