Upgrade to Groovy 4.0 #1114
Draft
Upgrade to Groovy 4.0 #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
groovy 4 support: https://github.com/spockframework/spock/releases/tag/spock-2.2-M1 |
olovy
force-pushed
the
feature/groovy-4
branch
2 times, most recently
from
5706fe7
to
fcf76a9
Compare
|
Gretty is still not working... |
olovy
force-pushed
the
feature/groovy-4
branch
from
f4458aa
to
d6577bb
Compare
|
Rebased on develop |
|
Gretty is still not working due to grettyStarter pulling in Gradle's internal Groovy version |
Seems like a new groovy compiler bug.
Works in 3.0.9 and 4.0.2 but not in 4.0.4.
Among other things static imports fail for constants in whelk.JsonLd.
```
/home/olov/kod/librisxl/whelk-core/build/tmp/compileGroovy/groovy-java-stubs/se/kb/libris/Normalizers.java:2: error: cannot find symbol
import static whelk.JsonLd.ID_KEY;
```
Looks like it's an issue with joint Java + Groovy compilation
("groovy-java-stubs")
DocumentSpec > Cannot set created FAILED
org.codehaus.groovy.runtime.typehandling.GroovyCastException: Cannot cast object '{@type=Publication, place={@type=Place, label=Stuttgart}, agent={@type=Agent, label=Thieme}}' with class 'java.util.LinkedHashMap' to class 'java.util.Collection' due to: groovy.lang.GroovyRuntimeException: Could not find matching constructor for: java.util.Collection(LinkedHashMap)
at whelk.converter.marc.MarcFieldHandler.convert_closure15(MarcFrameConverter.groovy:2145)
at groovy.lang.Closure.call(Closure.java:418)
at whelk.converter.marc.MarcFieldHandler.convert(MarcFrameConverter.groovy:2128)
at whelk.converter.marc.MarcRuleSet.processFields_closure6(MarcFrameConverter.groovy:756)
at groovy.lang.Closure.call(Closure.java:418)
at whelk.converter.marc.MarcRuleSet.processFields(MarcFrameConverter.groovy:753)
at whelk.converter.marc.MarcRuleSet.convert(MarcFrameConverter.groovy:746)
at whelk.converter.marc.MarcConversion.convert(MarcFrameConverter.groovy:274)
at whelk.converter.marc.MarcFrameConverter.runConvert(MarcFrameConverter.groovy:81)
at whelk.converter.marc.MarcFrameConverter.convert(MarcFrameConverter.groovy:107)
at whelk.DocumentSpec.Cannot set created(DocumentSpec.groovy:374)
olovy
force-pushed
the
feature/groovy-4
branch
from
d6577bb
to
dcfd377
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI draft.
Spock is not yet compatible with Groovy 4
spockframework/spock#1374