Feature/merge works in ldimport #1171
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…transaction This is necessary because the fundamental data integrity rules do not allow two records to hold the same URI at the same time. In other words: 1. We can't first write URIs from the disappearing record to the remaining one. As that would mean both having the URIs at the same time (forbidden). 2. We can't delete the disappearing record first, and then write the URIs to the remaining one, because that would require holding the URIs in volatile memory only for a short while in between. If the process was to die or be cancelled during this window, the URIs would be permanently lost. Therefore the removal and transfer of URIs need to happen within one and the same transaction.
jannistsiroyannis
requested review from
niklasl,
andersju,
klngwll,
kaipoykio,
lrosenstrom,
olovy,
kwahlin and
henrikb77
The code in question was taken as is from commit 3d2882c and moved into whelk-core.
…al branch" This reverts commit 8758d0f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step towards merging "tidnings-verk" from signe.
It handles all the basic data integrity, breaking off or creating works, relinking and so on of the signe works.
It does not however yet handle actually merging any of the contents of the works (this will be step 2).
It also does not mess with any existing functionality.
I'd like to merge this first, before going after the merge-code Olov wrote on another branch. I don't want to risk diverging too far from develop.