Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/lxl 4150 deduplicate contribution #1281

Merged
merged 6 commits into from
Aug 31, 2023

Conversation

kwahlin
Copy link
Contributor

@kwahlin kwahlin commented Jul 6, 2023

@niklasl niklasl self-requested a review August 16, 2023 11:58
Copy link
Member

@niklasl niklasl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should revise this to only apply a mergeContributionOnAgent in the whelktool script for now. See the Jira issue for detailed reasons.

@@ -179,6 +179,33 @@ class Normalizers {
})
}

static DocumentNormalizer contribution() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to mergeContributionsByAgent?

@kwahlin kwahlin force-pushed the feature/lxl-4150-deduplicate-contribution branch from 3076dc2 to 87d7d1e Compare August 22, 2023 13:02
@kwahlin
Copy link
Contributor Author

kwahlin commented Aug 22, 2023

We should revise this to only apply a mergeContributionOnAgent in the whelktool script for now. See the Jira issue for detailed reasons.

Ok! Let's limit this to a one-off normalization on svsk records.

Copy link
Member

@niklasl niklasl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@kwahlin kwahlin merged commit 465925b into develop Aug 31, 2023
1 check passed
@kwahlin kwahlin deleted the feature/lxl-4150-deduplicate-contribution branch November 9, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants