Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set FilterRange in command line? #47

Closed
acrouzet opened this issue Sep 26, 2024 · 3 comments · Fixed by #48
Closed

Set FilterRange in command line? #47

acrouzet opened this issue Sep 26, 2024 · 3 comments · Fixed by #48
Assignees
@drfiemost
Milestone
2.10

Comments

@acrouzet
Copy link

No description provided.

@drfiemost drfiemost self-assigned this Sep 26, 2024
@drfiemost drfiemost added this to the 2.10 milestone Sep 26, 2024
@ruby-R53
Copy link
Contributor

ruby-R53 commented Sep 27, 2024 •
edited
Loading

i was thinking of suggesting that as well

EDIT: or suggesting the filter parameters setup to be similar to the way VICE's player does, which's by sliding across milivolt values and not selecting some 0 to 1 double values, the former is much more intuitive (at least to me) but i'm not sure if it's doable here

drfiemost added a commit that referenced this issue Sep 27, 2024
@drfiemost
Allow setting filter range from command line (#47)
00bcd6d
@drfiemost drfiemost linked a pull request Sep 27, 2024 that will close this issue
Allow setting filter range from command line (#47) #48
Merged
drfiemost added a commit that referenced this issue Sep 29, 2024
@drfiemost
Allow setting filter range from command line (#47)
1c78517
@drfiemost
Copy link
Member

EDIT: or suggesting the filter parameters setup to be similar to the way VICE's player does, which's by sliding across milivolt values and not selecting some 0 to 1 double values, the former is much more intuitive (at least to me) but i'm not sure if it's doable here

For now I'll keep the 0..1 range to maintain compatibility. Also the filter range is measured in A/V^2, not really user friendly.

@ruby-R53
Copy link
Contributor

yeah that makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drfiemost drfiemost

Labels
None yet
Projects
None yet
Milestone
2.10
Development

Successfully merging a pull request may close this issue.

Allow setting filter range from command line (#47) libsidplayfp/sidplayfp
3 participants
@drfiemost @acrouzet @ruby-R53