Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: Get Bluetooth device Model Number String instead of Device Name into product string #500

Merged
merged 2 commits into from
Mar 12, 2023

Conversation

DJm00n
Copy link
Contributor

@DJm00n DJm00n commented Jan 27, 2023

Use Device Name only if Model Number String is not available. This should better match what we have in USB_DEVICE_DESCRIPTOR.iProduct

See Bluetooth Device Information Service spec for more info.

…vice Name (UUID: 0x2A00) into hid_device_info.product_string.

Use Device Name only if Model Number String is not available.

See [Device Information Service](https://www.bluetooth.com/specifications/specs/device-information-service-1-1/) spec for more info.
@DJm00n DJm00n changed the title Get Bluetooth device Model Number String instead of Device Name into product string windows: Get Bluetooth device Model Number String instead of Device Name into product string Jan 27, 2023
@mcuee mcuee added the Windows Related to Windows backend label Jan 28, 2023
windows/hid.c Outdated Show resolved Hide resolved
Copy link
Member

@Youw Youw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more comments, thanks

Copy link
Member

@Youw Youw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DJm00n please check if I accidentally didn't break anything. I don't have an actual BLE device to check this.

@DJm00n
Copy link
Contributor Author

DJm00n commented Mar 12, 2023

@Youw looks good. thanks

@Youw Youw merged commit e6caff3 into libusb:master Mar 12, 2023
@DJm00n DJm00n deleted the ble_better_product_string branch March 12, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Windows Related to Windows backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants