-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS: send report id conditionally for hid_get_feature_report #70
Conversation
This will likely reference #60. @DanielVanNoord, @micolous, please try if this works with your device(s). |
same as in hid_send_feature_report, and Windows/Linux
e966f66
to
47b042c
Compare
@DanielVanNoord, @micolous ping hidapi team, your opinion/feedback is needed @z3ntu, you have originally propagated #3, so you feedback is appreciated too |
Apparently the devices I use hidapi with, don't use numbered reports. I'll test this PR tomorrow if it works with my application! |
Thanks. If this works for you, I think we will accept it this was. |
Works fine for my use case 👍 |
@Qbicz, if you don't have comments regarding the implementation, I'd like to merge this ASAP |
@Youw I'll grab a Mac and test it with my devices that use report ids today. Will let you know the results as soon as I can. |
@Youw it looks good to me. I don't have a Mac setup so I didn't notice the problem before. Let's wait for @DanielVanNoord test result. |
meanwhile found bug in my own implementation |
Ran some quick tests on a Mac with a device that uses feature report ids and everything seems to be working. |
great, we have a winner here |
same as in hid_send_feature_report, and Windows/Linux