test: skip the pwd_shell test on IBMi #2592
Conversation
On IBMi PASE, the value of pw_shell is always an empty string.
There was a problem hiding this comment.
I'm a little undecided on whether it'd be better to change uv_os_get_passwd() to set pwd->shell to NULL or e.g. "/bin/sh" when pw_shell is an empty string. Thoughts?
The Windows implementation of uv_os_get_passwd() always sets pwd->shell = NULL but UNIX users may have the (reasonable?) expectation that it's always set to something. From man 5 passwd:
This is the program to run at login (if empty, use /bin/sh).
|
I will discuss with the API owner to see if the returned empty string is working as design. If so, we may assert that |
|
Based on the document , the default shell of a user is empty. We have to set it manually. When I called the procedure the test of Seems we should not overwrite the value if it exist. It could be an empty string or a meaningful value. So shall we keep current patch to let IBMi PASE pass the test? |
|
Overly cautious CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1705/ |
|
CI seems fine. This can land, but I'll wait in case @bnoordhuis wants to weigh in, based on #2592 (review). No rush since this just changes a test for a platform that isn't in the CI 😄 |
On IBMi PASE, the value of pw_shell is always an empty string. PR-URL: #2592 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1766/. Seems fine - the issues are unrelated to this PR, and have been fixed since this PR branch was created. Landed in 174a6ed. Thanks! |
On IBMi PASE, the value of pw_shell is always an empty string.
Seems the API getpwuid_r() is not fully implemented on PASE.