Skip to content

Commit

Permalink
PHP 8.4 support (#258)
Browse files Browse the repository at this point in the history
  • Loading branch information
deluxetom authored Jan 10, 2025
1 parent a8cc66c commit f158e3e
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
11 changes: 7 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on: [ push, pull_request ]
jobs:
CI:
name: ${{ matrix.php }}
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
strategy:
fail-fast: false
matrix:
Expand All @@ -15,21 +15,24 @@ jobs:
- php: '8.1'
- php: '8.2'
- php: '8.3'
- php: '8.3'
- php: '8.4'

steps:
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php }}
ini-values: zend.max_allowed_stack_size=-1
ini-values: zend.max_allowed_stack_size=-1,ffi.enable=true
extensions: ffi, exif
tools: composer:v2
coverage: none

- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install vips
run: sudo apt install -y libvips --no-install-recommends
run: sudo apt install -y --no-install-recommends libvips

- name: Install composer dependencies
run: |
Expand Down
2 changes: 1 addition & 1 deletion src/Exception.php
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
*/
class Exception extends \Exception
{
public function __construct($message = "", $code = 0, \Throwable $previous = null)
public function __construct($message = "", $code = 0, ?\Throwable $previous = null)
{
if ($message == "") {
$message = "libvips error: " . FFI::vips()->vips_error_buffer();
Expand Down

0 comments on commit f158e3e

Please sign in to comment.