Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint code #402

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Lint code #402

merged 1 commit into from
Aug 2, 2024

Conversation

rodrigoargumedo
Copy link
Contributor

Hi,

I saw that the linting Actions job was failing and decided to correct it to pass.

From standardrb:

Style/SuperArguments: Call super without arguments and parentheses when the signature is identical

Please let me know if you have any questions for me.

@jcupitt
Copy link
Member

jcupitt commented Aug 2, 2024

Hi @rodrigoargumedo,

Ahhh they keep adding new rules and breaking our CI. Sure, happy to change this, though the lint is still failing (not sure why).

@rodrigoargumedo
Copy link
Contributor Author

@jcupitt Thanks for the quick response. Do we want to enforce this rule or exclude it from being linted?

@jcupitt
Copy link
Member

jcupitt commented Aug 2, 2024

The rule sounds reasonable, so let's make this change. Thanks for volunteering!

@kleisauke
Copy link
Member

It seems that the failing CI job was run on commit 7a2b9ba. I tried restarting it, but to no avail.
https://github.com/libvips/ruby-vips/actions/runs/10216871731/job/28270880174#step:2:70

@rodrigoargumedo
Copy link
Contributor Author

It's failing due to branch is not equal to master and is on a feature branch that I forked from. So, this is a normal expected behavior to fail this way.

@rodrigoargumedo
Copy link
Contributor Author

Once merged, it will pass.

@kleisauke
Copy link
Member

Ah, I think it's due to this:

pull_request_target:
branches:
- master

@jcupitt jcupitt merged commit e230802 into libvips:master Aug 2, 2024
21 of 22 checks passed
@jcupitt
Copy link
Member

jcupitt commented Aug 2, 2024

Ah! Of course. I assumed it was linting the branch. Thanks again.

@rodrigoargumedo rodrigoargumedo deleted the fix-lint branch August 2, 2024 14:37
@kleisauke
Copy link
Member

PR #403 removes this confusing pull_request_target event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants