Use mapAccumulateFilter

[Masynchin]

This is PR in advance, because it relies on adding mapAccumulateFilter to cats (typelevel/cats#4561).

Besides that I have replaced foldLeft in updateOrGiveUp with mapAccumulateFilter, I have also added new clearOrGiveUp method to AppState and use it in Executor.move.

I want to denote two things I have observed:

1. Is state.updated(task.id, unAssignedTask) same as state.add(updated)? It seems yes for me, but I am not sure.
2. clearOrGiveUp naming. I have bad intuition in the semantics of the project, so I would be happy if you choose better name for this method.

[Masynchin]

I would be happy if you choose better name for this method

Edits by maintainers are allowed

[lenguyenthanh]

this refactor is great, and the name as you mentioned can be improved. I think both updateOrGiveUp and clearOrGiveUp can be renamed to unassignOrGiveup.

[lenguyenthanh]

The cats library will take a long time to release, I think we can use mapAccumulateFilter when it is available. For now, do you mind to create another PR for clearOrGiveUp/unassignOrGiveup function?

[Masynchin]

The cats library will take a long time to release, I think we can use mapAccumulateFilter when it is available. For now, do you mind to create another PR for clearOrGiveUp/unassignOrGiveup function?

Sure, will be in the second

[lenguyenthanh]

@Masynchin would you mind if I close this? You're welcome to create another pr for mapAccumulateFilter when it's ready.

[Masynchin]

@Masynchin would you mind if I close this?

Sure, no problemo!